Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What about links without protocol but has www? #11

Open
hammertimedk opened this issue Feb 8, 2014 · 6 comments
Open

What about links without protocol but has www? #11

hammertimedk opened this issue Feb 8, 2014 · 6 comments

Comments

@hammertimedk
Copy link

What about url's without protocol, but where a user has entered dub dub dub? I'd say something like www.google.com should be autolinked if found in a string ... Am I missing something? :)

@hammertimedk
Copy link
Author

Maybe for extra fancyness look for common tld's in the string instead of relying on www as users might type in something.com/org/net/whatever

@dandv
Copy link

dandv commented Feb 21, 2014

@hammertimedk: check out more advanced libraries - see issue #12.

@mac2000
Copy link
Contributor

mac2000 commented Feb 21, 2014

Why not, if there will be PR that will do that and will be tested - it will be nice addition

After all pretty of this library is that it is lightweight and have no dependencies

@dandv
Copy link

dandv commented Feb 21, 2014

@mac2000: the Component URL regexp is way more lightweight and has no dependencies.

It's used by https://github.com/juliangruber/find-urls

@mac2000
Copy link
Contributor

mac2000 commented Feb 21, 2014

Oh, I see, thank you for your response it is really cool

May be we should also use that regexps to make this library DRY and recognizable by other developers

@bryanwoods
Copy link
Owner

@dandv I would happily merge a pull request that uses that component URL regexp if the existing tests pass.

@mac2000 I think that's a great idea :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants