-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
What about links without protocol but has www? #11
Comments
Maybe for extra fancyness look for common tld's in the string instead of relying on www as users might type in something.com/org/net/whatever |
@hammertimedk: check out more advanced libraries - see issue #12. |
Why not, if there will be PR that will do that and will be tested - it will be nice addition After all pretty of this library is that it is lightweight and have no dependencies |
@mac2000: the Component URL regexp is way more lightweight and has no dependencies. It's used by https://github.com/juliangruber/find-urls |
Oh, I see, thank you for your response it is really cool May be we should also use that regexps to make this library DRY and recognizable by other developers |
What about url's without protocol, but where a user has entered dub dub dub? I'd say something like www.google.com should be autolinked if found in a string ... Am I missing something? :)
The text was updated successfully, but these errors were encountered: