-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix css styles for the cheat sheet so that scrolling is working #90
Conversation
Thank you for submitting a pull request, that's always appreciated. Sorry about the slow response, struggling to find the time to spend on the computer during the summer. I checked this out and it looks good. It does seem to always create a scrollbar, even when it's not needed, which I'm not a fan of. I tried a few quick tweaks to see if I could find an easy fix but I could get anything in place that also made it work when the scrollbar was needed. I can take a closer look at it, but that could take me a few, to a couple of, weeks to get around to. If you'd like to take a stab at it I'll try to find time sooner to just look at it again. |
Sorry for not getting back to you earlier. It's been a busy summer and it'll keep being busy for another couple of weeks I'm afraid. I only had a chance to very quickly test this out and I did get a scrollbar on the cheatsheet. But since you're not seeing it I feel like I should test it out some more to try and figure out what's going on so I can give a more reliable use case where it happens. Unfortunately this is unlike to happen before second half of august. I haven't forgotten about this PR though, so don't worry. :) |
vertical-align: middle; | ||
} | ||
|
||
.cfp-hotkeys-table{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just for consistency's sake I'd love to see a space before the bracket, like this:
.cfp-hotkeys-table{ | |
.cfp-hotkeys-table { |
Bug: #89