Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose module.parent as in node #47

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

dominictarr
Copy link
Contributor

This pr resolves browserify/browserify#976
It only makes the prelude 23 bytes longer, this will help more node modules work in the browser by default.

@dominictarr
Copy link
Contributor Author

bump

@dominictarr
Copy link
Contributor Author

really this should be merged because it makes browserify more consistent with node.

@terinjokes
Copy link

@dominictarr can you update this PR to point at another branch?

@dominictarr
Copy link
Contributor Author

@terinjokes not sure I follow, do you want me to update this merge cleanly with current master?
which branch?

@terinjokes
Copy link

@dominictarr I'm sorry, I was unclear. This PR points at your fork's master branch, which you've since pushed changes to rename it to nodepack.

Without those changes, this looks to apply cleanly. I don't mind cherrypicking, so not too much of a problem.

@dominictarr
Copy link
Contributor Author

oh, I see, sorry about that. I'll fix this.

@dominictarr
Copy link
Contributor Author

dominictarr commented Jun 9, 2016

okay I refactored to this branch https://github.com/dominictarr/nodepack/tree/parent
but turns out browser-pack has changed a lot since I did this so it' doesn't merge anymore
(i tried but tests break)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--bare needs to support module.parent so that node modules work correctly
3 participants