Update fold #64
Open
Update fold #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cy not autoimpl'ing FoldInAllowed
…fix to prevent laundering NoFoldIn
* Remove FoldIn trait and replace it with direct impl over BBox * Get RuntimeFoldIn to work with the type erased dyn obj in AnyPolicy * Improve specialization bounds of RuntimeFoldIn so that we can override it for AnyPolicy, RefPolicy, AndPolicy, OrPolicy, TestPolicy, and OptionPolicy * split foldin code into several files * use static_asserts to make the previously commented out compile-time deny tests functional
KinanBab
commented
Oct 21, 2024
| Box::new(self.clone()) | ||
| } | ||
| fn can_fold_in_boxed(&self) -> bool { |
There was a problem hiding this comment.
@corinnt this line below was what was needed to get the dyn TypeIdPolicyTrait objects to play ball with RuntimeFoldIn
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.