-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Josh/nolan localfilesave #303
base: horizon
Are you sure you want to change the base?
Conversation
Changed editor.html to have relative paths to work with web version and app version Created build_experiment to have electron working files: -editor.html: change {{GOOGLE_API_KEY}} to empty string Changed package.json to have start-web and start-app to open either web version or app version from code.pyret.org
Trying to fix the path to the pyret-spin gif
Basic changes for Electron usage
…ing functionality so that when you save it knows to auto-save in the future and when you have opened it continues to autosave the correct file
…y' button -- annotations for code can be found by looking for '(Josh) 2/28/19...'
@blerner I'm assuming that
OK to close? |
I've never seen this code before. I don't know what it is intended to do... |
This was a great idea at the time. It will be superseded by other save-to-localstorage/indexedDB solutions before we can make use of it, though. |
(This was actually really great work that went a little beyond just local file saving. It was an electron-hosted container for CPO for offline use.) |
Well that does sound cool! 👍 |
Actually now I'm realizing it still has some good ideas. Looking at the diff is probably useful, and actually only package* conflict. It's kind of orthogonal to what's going on on the page. And since we have BrowserFS presumably we can swap in real |
First merge