feat: isolate test suite #99

cpaniaguam · 2024-02-01T15:30:23Z

Add test data files for steps 2-5. This includes new data sets that will be used for testing the functionality of steps 2 through 5
Handle tar.gz files via Git Large File Storage (LFS)
Add tests for step 1.

Once PRs #90, #92 , #94 (cli's for steps 2-4) are merged the commented code in test_steps.py can be uncommented and then update the CI workflow to run all tests via the test suite.

#96

This commit updates the test-B01_SL_load_single_file.yml workflow file. It changes the name of the workflow to "Test steps" and updates the runs-on value to "ubuntu-latest". Additionally, it adds a step to enable Git LFS and installs pytest and its dependencies. Finally, it updates the run command for the first step and adds a new step to run tests using pytest.

…icesat2-tracks into 96-isolate-test-suite

kmilo9999

How you feel about renaming the CI workflow file? test.yml is too general.

cpaniaguam · 2024-02-01T20:57:38Z

How you feel about renaming the CI workflow file? test.yml is too general.

I am open. What would be a better name? Naming things is sometimes tricky! @kmilo9999

kmilo9999 · 2024-02-01T21:46:11Z

Reference

what about test_icesat2_pipeline.yml. The value of the name tag can be changed to the same name

cpaniaguam · 2024-02-02T17:18:34Z

Reference

what about test_icesat2_pipeline.yml. The value of the name tag can be changed to the same name

I like that name! Do we anticipate having other pipelines other than the one for the icesat2 package? @kmilo9999

kmilo9999 · 2024-02-02T18:19:57Z

Reference

what about test_icesat2_pipeline.yml. The value of the name tag can be changed to the same name

I like that name! Do we anticipate having other pipelines other than the one for the icesat2 package? @kmilo9999

I dont know. We can rename the file again if new pipelines appear and there's a way to distinguish between them.

cpaniaguam · 2024-02-02T18:22:33Z

I dont know. We can rename the file again if new pipelines appear and there's a way to distinguish between them.

Do you believe in YAGNI? @kmilo9999

kmilo9999 · 2024-02-02T19:09:17Z

I dont know. We can rename the file again if new pipelines appear and there's a way to distinguish between them.

Do you believe in YAGNI? @kmilo9999

I do believe in it. I just want to have a clear idea that the file runs the pipeline's tests.

kmilo9999 · 2024-02-12T18:34:49Z

Review and merge this PR after CLI full integration.

hollandjg

(Just marking this as needing changes – uncommenting the commented-out tests – so it disappears from the list of needed reviews. Thanks!)

hollandjg

Hi Carlos, thanks for this! It looks like a well thought through method of isolating the testing of each of the steps.
I've got some suggestions for simplifications and changes, and some requests for more info!

.github/workflows/test_icesat2_tracks_pipeline.yml

tests/test_steps.py

.gitattributes

tests/test_steps.py

.github/workflows/test_icesat2_tracks_pipeline.yml

Use it to define script1

…icesat2-tracks into 96-isolate-test-suite

tdivoll

The code looks good and it seems like many suggestions have already been incorporated. I just found some small text cleanups.

.github/workflows/test_icesat2_tracks_pipeline.yml

tests/test_steps.py

Co-authored-by: Timothy Divoll <[email protected]>

cpaniaguam · 2024-02-28T19:13:57Z

The code looks good and it seems like many suggestions have already been incorporated. I just found some small text cleanups.

Thanks @tdivoll!

tdivoll

Just a couple formatting things that seem like they didn't come through in the last commit. I unresolved a couple of the comments to make it easier to find them.

Co-authored-by: Timothy Divoll <[email protected]>

tdivoll

Looks good to me!

kmilo9999

looks good to me

hollandjg

Seems to work!

hollandjg · 2024-03-01T15:49:15Z

.github/workflows/test_icesat2_tracks_pipeline.yml

The changes to this file are no longer related to the main change, so we could split these out. But I think they are fine.

cpaniaguam added 5 commits January 31, 2024 15:58

Add new files and directories to .gitignore

4134845

feat: handle tar.gz via lfs

a937cbc

feat: add test data files for steps 2-5

f870e1b

refactor: test_steps

b7db6e7

cpaniaguam added the enhancement New feature or request label Feb 1, 2024

cpaniaguam self-assigned this Feb 1, 2024

fix: remove old script runs outside test suite

52046b9

cpaniaguam requested review from hollandjg and kmilo9999 February 1, 2024 15:41

cpaniaguam added 2 commits February 1, 2024 11:21

fix: remove unnecessary steps from and rename to tests

4d2f223

Merge branch '96-isolate-test-suite' of https://github.com/brown-ccv/…

1a87f84

…icesat2-tracks into 96-isolate-test-suite

kmilo9999 requested changes Feb 1, 2024

View reviewed changes

cpaniaguam changed the base branch from 93-cli-step-4-a02c_iowaga_thredds_priorpy to 95-cli-step-5-b04_anglepy February 9, 2024 15:30

hollandjg requested changes Feb 12, 2024

View reviewed changes

kmilo9999 added 4 commits February 13, 2024 05:47

added test dependecies

c97573d

merge with main

3439ff0

renamed github workflow file

0d1dbf2

restoring test.yml file

2eb7063

Base automatically changed from 95-cli-step-5-b04_anglepy to 93-cli-step-4-a02c_iowaga_thredds_priorpy February 16, 2024 23:51

fixed test step 3

980d30b

Base automatically changed from 93-cli-step-4-a02c_iowaga_thredds_priorpy to 91-cli-step-3-b03_plot_spectra_ovpy February 17, 2024 05:37

Base automatically changed from 91-cli-step-3-b03_plot_spectra_ovpy to 89-cli-step-2-b02_make_spectra_gft February 17, 2024 06:10

cpaniaguam added 2 commits February 26, 2024 11:39

fix: restore original smoke test workflow with verbose

df023e6

ci: workflow with test suite

276b1b0

hollandjg requested changes Feb 26, 2024

View reviewed changes

cpaniaguam added 4 commits February 26, 2024 14:37

refactor: create_script function to accept track_name parameter

fe27354

Use it to define script1

fix: restore .gitignore

f2fe347

docs: add module level docstring and some comments

7a37d26

Merge branch '96-isolate-test-suite' of https://github.com/brown-ccv/…

4511492

…icesat2-tracks into 96-isolate-test-suite

cpaniaguam requested review from hollandjg, mirestrepo, paulstey, broarr, digicosmos86, tdivoll, jashlu and gtdang February 26, 2024 22:34

tdivoll requested changes Feb 28, 2024

View reviewed changes

cpaniaguam mentioned this pull request Feb 28, 2024

m_general_ph3.save_anyfig appends png extension #135

Open

Apply suggestions from code review

b362171

Co-authored-by: Timothy Divoll <[email protected]>

cpaniaguam requested a review from tdivoll February 29, 2024 16:03

tdivoll previously approved these changes Feb 29, 2024

View reviewed changes

Apply suggestions from code review

c9a02df

Co-authored-by: Timothy Divoll <[email protected]>

cpaniaguam dismissed tdivoll’s stale review via c9a02df February 29, 2024 17:37

cpaniaguam requested a review from tdivoll February 29, 2024 17:38

Apply suggestions from code review

b1da226

Co-authored-by: Timothy Divoll <[email protected]>

tdivoll approved these changes Feb 29, 2024

View reviewed changes

kmilo9999 approved these changes Mar 1, 2024

View reviewed changes

hollandjg approved these changes Mar 1, 2024

View reviewed changes

cpaniaguam merged commit a737360 into main Mar 1, 2024
2 checks passed

cpaniaguam deleted the 96-isolate-test-suite branch March 1, 2024 16:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: isolate test suite #99

feat: isolate test suite #99

cpaniaguam commented Feb 1, 2024

kmilo9999 left a comment •

edited

Loading

cpaniaguam commented Feb 1, 2024

kmilo9999 commented Feb 1, 2024

cpaniaguam commented Feb 2, 2024

kmilo9999 commented Feb 2, 2024

cpaniaguam commented Feb 2, 2024

kmilo9999 commented Feb 2, 2024

kmilo9999 commented Feb 12, 2024

hollandjg left a comment •

edited

Loading

hollandjg left a comment

tdivoll left a comment

cpaniaguam commented Feb 28, 2024

tdivoll left a comment

tdivoll left a comment

kmilo9999 left a comment

hollandjg left a comment

hollandjg Mar 1, 2024

feat: isolate test suite #99

feat: isolate test suite #99

Conversation

cpaniaguam commented Feb 1, 2024

kmilo9999 left a comment • edited Loading

Choose a reason for hiding this comment

cpaniaguam commented Feb 1, 2024

kmilo9999 commented Feb 1, 2024

cpaniaguam commented Feb 2, 2024

kmilo9999 commented Feb 2, 2024

cpaniaguam commented Feb 2, 2024

kmilo9999 commented Feb 2, 2024

kmilo9999 commented Feb 12, 2024

hollandjg left a comment • edited Loading

Choose a reason for hiding this comment

hollandjg left a comment

Choose a reason for hiding this comment

tdivoll left a comment

Choose a reason for hiding this comment

cpaniaguam commented Feb 28, 2024

tdivoll left a comment

Choose a reason for hiding this comment

tdivoll left a comment

Choose a reason for hiding this comment

kmilo9999 left a comment

Choose a reason for hiding this comment

hollandjg left a comment

Choose a reason for hiding this comment

hollandjg Mar 1, 2024

Choose a reason for hiding this comment

kmilo9999 left a comment •

edited

Loading

hollandjg left a comment •

edited

Loading