Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add some instructions for HDF5-dependency #49

Merged
merged 2 commits into from
Jan 11, 2024
Merged

Conversation

hollandjg
Copy link
Member

No description provided.

@hollandjg hollandjg requested a review from kmilo9999 December 15, 2023 19:25
@hollandjg hollandjg mentioned this pull request Dec 15, 2023
@hollandjg hollandjg requested a review from cpaniaguam December 15, 2023 19:28
README.md Show resolved Hide resolved
kmilo9999
kmilo9999 previously approved these changes Dec 15, 2023
README.md Show resolved Hide resolved
Base automatically changed from feat-step2-intg to main December 15, 2023 21:32
@kmilo9999 kmilo9999 dismissed their stale review December 15, 2023 21:32

The base branch was changed.

Copy link
Member

@cpaniaguam cpaniaguam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggesting adding a line for consistency. Thanks!

README.md Outdated
@@ -31,6 +32,18 @@ Installation:
```shell
pip install --upgrade --editable ".[dev]"
```
> You may need to set the value of the `HDF5_DIR` environment variable to install some of the dependencies, especially when installing on macOS. For Apple Silicon (M-Series) CPUs:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
> You may need to set the value of the `HDF5_DIR` environment variable to install some of the dependencies, especially when installing on macOS. For Apple Silicon (M-Series) CPUs:
> You may need to set the value of the `HDF5_DIR` environment variable to install some of the dependencies, especially when installing on macOS.
For Apple Silicon (M-Series) CPUs:

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this suggestion, Carlos! I've included it in the updated version.

@hollandjg hollandjg requested a review from cpaniaguam January 11, 2024 16:09
Copy link
Member

@cpaniaguam cpaniaguam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@hollandjg hollandjg merged commit b863b3b into main Jan 11, 2024
1 check passed
@hollandjg hollandjg deleted the add-hdf5-instructions branch January 11, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants