Run test on step 1 #41
Conversation
kmilo9999
commented
Nov 15, 2023
kmilo9999
commented
- Workflow to test step 1 integration
added workflow to test B01_SL_load_single_file
change workflow name
changed on property to 'pull_request'
There was a problem hiding this comment.
Hi Camilo,
it looks like this isn't passing, because it's missing the `config.json file. You'll need to update the pyproject.toml line 154:
[tool.setuptools]
# If there are data files included in your packages that need to be
# installed, specify them here.
# TODO: ADD ANY DATA FILES WE WANT TO HAVE
package-data = {"icesat2_tracks" = ["config/*.json"]}…sat2-tracks into feature-test-step1
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| version: ['3.9'] |
There was a problem hiding this comment.
Can other versions be added here? I think some code needed python 3.10 or 3.11 but I could be wrong on this.
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: install mpi | ||
| run: sudo apt update && sudo apt-get install openmpi-bin openmpi-doc libopenmpi-dev |
There was a problem hiding this comment.
Why was this needed? Maybe add a comment?
| - name: install icesat2-tracks using pip | ||
| run: pip install . | ||
| - name: first step B01_SL_load_single_file | ||
| run: python src/icesat2_tracks/analysis_db/B01_SL_load_single_file.py 20190502052058_05180312_005_01 SH_testSLsinglefile2 True |
There was a problem hiding this comment.
Note to self: I guess this might be a command to add to CLI.
There was a problem hiding this comment.
What is this file for? Maybe some comments can be added at the top to describe its purpose?
There was a problem hiding this comment.
Is this file needed to set up the CI?
| B=dict() | ||
| for i in A[0]['swatches']: | ||
| B[i['name']] = i['data']['values'] | ||
| print(i['name'] + ' ' + str(i['data']['values'])) |
There was a problem hiding this comment.
| print(i['name'] + ' ' + str(i['data']['values'])) |
I guess we are not refactoring stuff yet, but this print statement can probably be deleted and use a dict comprehension to populate B.
| rels=dict() | ||
|
|
||
|
|
||
| rels['plus']=B['red'] | ||
| rels['minus']=B['blue'] | ||
|
|
||
| rels['blue']=B['blue'] | ||
| rels['lightblue']=B['cascade3'] | ||
| rels['darkblue']=B['cascade1'] | ||
|
|
||
|
|
||
| rels['white']=B['white'] | ||
| rels['gridcolor']=B['gridcolor'] | ||
| rels['grey']=B['gray'] | ||
|
|
||
| rels['orange']=B['orange'] | ||
| rels['red']=B['red'] | ||
| rels['green']=B['green'] | ||
|
|
||
| rels['cascade1']=B['cascade1'] | ||
| rels['cascade2']=B['cascade2'] | ||
| rels['cascade3']=B['cascade3'] | ||
| rels['cascade4']=B['gridcolor'] | ||
|
|
||
| rels['rascade1']=B['rascade2'] | ||
| rels['rascade2']=B['rascade1'] | ||
| rels['rascade3']=B['rascade3'] | ||
|
|
||
| rels['aug1']=B['orange'] | ||
| rels['aug2']=B['green'] | ||
|
|
||
| rels['gt1l']=B['rascade1'] | ||
| rels['gt1r']=B['rascade3'] | ||
|
|
||
| rels['gt2l']=B['green1'] | ||
| rels['gt2r']=B['green2'] | ||
|
|
||
| rels['gt3l']=B['cascade1'] | ||
| rels['gt3r']=B['blue'] | ||
|
|
||
| rels['group1']=B['rascade1'] | ||
| rels['group2']=B['green1'] | ||
| rels['group3']=B['cascade1'] | ||
|
|
||
| B['rels']=rels |
There was a problem hiding this comment.
This can probably be refactored as well but I guess we'll get that later.
There was a problem hiding this comment.
Can the template generic comments be removed now that the project is (completely?) set up?
There was a problem hiding this comment.
referenced in #43
