Refactor test suite test_steps.py to run step that takes the longest first #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pytest's `xdist` plug-in seems to assign test functions to workers in the order that they are listed in the file. Because default GitHub runners only have 4 cores, listed fifth `test_step5` -- the step that takes the longest to complete -- does not get picked up immediately. This PR lists this step before the others which should make things run much faster in general.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pytest's
xdistplug-in seems to assign test functions to workers in the order that they are listed in the file. Because default GitHub runners only have 4 cores, listed fifthtest_step5-- the step that takes the longest to complete -- does not get picked up immediately. This PR lists this step before the others; this should make things run much faster in general.