Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: icesat2waves commands #140

Merged
merged 3 commits into from
Mar 4, 2024
Merged

fix: icesat2waves commands #140

merged 3 commits into from
Mar 4, 2024

Conversation

cpaniaguam
Copy link
Member

There was a bug invoking the commands load-file (thanks @hollandjg for catching that one!) and make-iowaga-threads-prior from icesat2waves. This patch fixes those problems.

It also updates the workflow file to call the commands from the global app.

@cpaniaguam cpaniaguam added the bug Something isn't working label Feb 29, 2024
@cpaniaguam cpaniaguam self-assigned this Feb 29, 2024
Copy link
Collaborator

@kmilo9999 kmilo9999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but let's wait for John's approval.

Copy link
Member

@hollandjg hollandjg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HI Carlos, please could you split this up into a few separate PRs? I thought the bug fix was confined to app.py – the other things make it more complex to review and I've got more questions about the things which aren't fixing the bugs.

src/icesat2_tracks/app.py Show resolved Hide resolved
src/icesat2_tracks/app.py Outdated Show resolved Hide resolved
src/icesat2_tracks/app.py Outdated Show resolved Hide resolved
.github/workflows/test-B01_SL_load_single_file.yml Outdated Show resolved Hide resolved
Copy link
Member

@hollandjg hollandjg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@cpaniaguam cpaniaguam merged commit 7169d79 into main Mar 4, 2024
2 checks passed
@cpaniaguam cpaniaguam deleted the fix-icesat2waves-commands branch March 4, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants