-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: icesat2waves commands #140
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, but let's wait for John's approval.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HI Carlos, please could you split this up into a few separate PRs? I thought the bug fix was confined to app.py – the other things make it more complex to review and I've got more questions about the things which aren't fixing the bugs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
There was a bug invoking the commands
load-file
(thanks @hollandjg for catching that one!) andmake-iowaga-threads-prior
fromicesat2waves
. This patch fixes those problems.It also updates the workflow file to call the commands from the global app.