Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: format py files with black #109

Closed
wants to merge 1 commit into from
Closed

fix: format py files with black #109

wants to merge 1 commit into from

Conversation

cpaniaguam
Copy link
Member

No description provided.

@cpaniaguam cpaniaguam linked an issue Feb 6, 2024 that may be closed by this pull request
format all py files in project #108
Open
hollandjg
hollandjg reviewed Feb 7, 2024
View reviewed changes
Copy link
Member

@hollandjg hollandjg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Let's merge this one once we've merged everything else which is already done. Otherwise we're going to have to deal with tonnes of merge conflicts on every single file.

@cpaniaguam cpaniaguam self-assigned this Feb 7, 2024
kmilo9999
kmilo9999 reviewed Feb 9, 2024
View reviewed changes
Copy link
Collaborator

@kmilo9999 kmilo9999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should only format the scripts in under the source folder. We have plans of removing the ones in the root folder.

@cpaniaguam
Copy link
Member Author

cpaniaguam commented Feb 9, 2024 •
edited
Loading

I think we should only format the scripts in under the source folder. We have plans of removing the ones in the root folder.

@kmilo9999
Aren't more files from root/ going to be moved to src or is that done?

@kmilo9999
Copy link
Collaborator

I think we should only format the scripts in under the source folder. We have plans of removing the ones in the root folder.

@kmilo9999 Aren't more files from root/ going to be moved to src or is that done?

I think whatever we dont need in the root folder should be removed form the project after we integrate the whole CLI.

@kmilo9999
Copy link
Collaborator

We should do this after the CLI full integration.

@kmilo9999 kmilo9999 closed this Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmilo9999 kmilo9999 kmilo9999 left review comments

@hollandjg hollandjg hollandjg left review comments

Assignees

@cpaniaguam cpaniaguam

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

format all py files in project
3 participants
@cpaniaguam @kmilo9999 @hollandjg