ref: change all func taking in jspsych to const syntax / trials to co… #529
Conversation
|
Visit the preview URL for this PR (updated for commit f310479): https://ccv-honeycomb--pr529-ref-trial-cons-var-41ekwrl1.web.app (expires Wed, 21 Aug 2024 21:38:22 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 4ace1dcea913a952d2a1af84b94a4421bf36e610 |
src/experiment/trials/camera.js
Outdated
| console.error("Camera is not initialized, no data will be recorded."); | ||
| return; | ||
| } | ||
| const cameraRecorder = window.jsPsych.pluginAPI.getCameraRecorder(); |
There was a problem hiding this comment.
I commented on the other out window.jsPsych. What's the order of these PRs?
There was a problem hiding this comment.
Please let me know if this is not what you mean by order, but I think we should merge this branch into jsPsych-global and then merge jsPsych-global into feat-v4
There was a problem hiding this comment.
Okay! This one looks good. I did request some changes to #528 (review) which affects this PR in some ways.
So resolve those and this one looks good to go!
After removing
jsPsychpassed in as params injsPsych-globalbranch:procedures: change toconstfunction syntax, call functions in original placetrials: change toconstjsPsych trial object syntax, move variable declarations outside the object declaration when necessaryjsPsychas a parameter