Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add: commander to optionally provide delete or download along with st… #516
add: commander to optionally provide delete or download along with st… #516
Changes from 2 commits
37fcb29
bbc569d
aaf6969
aa1d143
ccaaf88
c2ec9eb
c8bfe5f
c48f5d6
6c83919
e25cb92
f32f1bb
4b3cfde
f0233ed
7089d92
3115f1e
c88c78e
a7acbf7
9239d7a
1cc9e92
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm... I know this is code I wrote but it looks a little funky to me. Are you okay changing it here?
I would return
true
orfalse
from this function and then inmain
where you have thatconsole.error
I would just call the string itself -console.error("Please enter a valid study from your Firestore database")
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.