Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: holdUpMarker as basic trial to line up photodiode spot and … #509

Merged
merged 2 commits into from
Jul 16, 2024

Conversation

YUUU23
Copy link
Contributor

@YUUU23 YUUU23 commented Jul 12, 2024

  • Move holdUpMarker code in to change original to a basic trial
  • Move countdownTrial to before preloadTrial in the timeline so the countdown will begin after serialport pop-up box (all set-up completed)

@YUUU23 YUUU23 self-assigned this Jul 12, 2024
Copy link

github-actions bot commented Jul 12, 2024

Visit the preview URL for this PR (updated for commit 1a5c733):

https://ccv-honeycomb--pr509-ref-holdupmarker-zvs9ts5j.web.app

(expires Sun, 21 Jul 2024 21:42:49 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4ace1dcea913a952d2a1af84b94a4421bf36e610

@YUUU23 YUUU23 requested a review from RobertGemmaJr July 12, 2024 03:55
Copy link
Member

@RobertGemmaJr RobertGemmaJr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm now realizing it's probably best to handle this as version 3.4.2 of the project. With the current setup the serial port is not actually connected until the following trial.

I think it would be best to handle some sort of call-function trial that calls the Electron setupPort function before continuing. This will take a little while, and tbh I think having a really solid setup for the serial port connection is worthy of it's own patch version - it's something that's always kind of been an issue with Honeycomb.

src/experiment/trials/holdUpMarker.js Outdated Show resolved Hide resolved
@RobertGemmaJr
Copy link
Member

Let's make the minor change I mentioned and then we'll create a 3.4.2 holding branch. From there we'll add the new trial as its own PR!

Base automatically changed from feat-v3.4.1 to main July 12, 2024 17:14
@RobertGemmaJr RobertGemmaJr changed the base branch from main to feat-v3.4.2 July 12, 2024 17:32
Co-authored-by: Robert Gemma <[email protected]>
@YUUU23 YUUU23 merged commit e86a916 into feat-v3.4.2 Jul 16, 2024
8 checks passed
@YUUU23 YUUU23 deleted the ref-holdupmarker branch July 16, 2024 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor holdUpMarker as a basic trial for lining up the photodiode spot
2 participants