Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: v3.4 Release #458

Merged
merged 55 commits into from
May 7, 2024
Merged
Show file tree
Hide file tree
Changes from 54 commits
Commits
Show all changes
55 commits
Select commit Hold shift + click to select a range
7d79abe
build: Upgrade to node20
RobertGemmaJr Mar 21, 2024
0c34ac7
chore: lock
RobertGemmaJr Mar 21, 2024
aec1a80
wip: delete current firebase actions
RobertGemmaJr Mar 21, 2024
aa6cffd
ci: Add new firebase hosting actions
RobertGemmaJr Mar 21, 2024
955b56d
ci: Update action to use ci and build:firebase
RobertGemmaJr Mar 21, 2024
883cfc0
chore: update linting settings
RobertGemmaJr Mar 21, 2024
4df1e8f
build: Add prop types library
RobertGemmaJr Mar 21, 2024
172829e
style: Add prop types to the react code
RobertGemmaJr Mar 21, 2024
43c8f68
chore: REMOVE IMAGE_INLINE_SIZE_LIMIT variable
RobertGemmaJr Mar 21, 2024
6a92b9a
Merge pull request #440 from brown-ccv/build-node20
RobertGemmaJr Mar 26, 2024
eed5b88
Merge branch 'ref-continue-anyway' into feat-v3.4
RobertGemmaJr Mar 26, 2024
8708e6e
Merge branch 'feat-v3.4' into ref-firebase-actions
RobertGemmaJr Mar 26, 2024
f05f4f8
Merge branch 'feat-v3.4' into feat-prop-validation
RobertGemmaJr Mar 26, 2024
1dae42d
Merge branch 'feat-v3.4' into chore-inline
RobertGemmaJr Mar 26, 2024
5895e8f
ref: Remove event-marker and install locally
RobertGemmaJr Mar 27, 2024
33527b0
chore: lock
RobertGemmaJr Mar 28, 2024
e5bee8f
chore: lock and todos
RobertGemmaJr Mar 28, 2024
a42b89f
chore: todo comments
RobertGemmaJr Mar 28, 2024
3eeba8f
chore: lock
RobertGemmaJr Apr 1, 2024
73cc282
Merge branch 'v3.3.1' into feat-v3.4
RobertGemmaJr Apr 3, 2024
da01970
Merge branch 'ref-logo' into feat-v3.4
RobertGemmaJr Apr 3, 2024
9885f91
merge
RobertGemmaJr Apr 3, 2024
ff5517a
Merge branch 'fix-python' into feat-v3.4
RobertGemmaJr Apr 3, 2024
367dc17
Merge branch 'feat-v3.4' into ref-firebase-actions
RobertGemmaJr Apr 3, 2024
0682092
Merge branch 'feat-v3.4' into feat-prop-validation
RobertGemmaJr Apr 3, 2024
274d400
Merge branch 'feat-prop-validation' into chore-inline
RobertGemmaJr Apr 3, 2024
5affe7c
Merge pull request #441 from brown-ccv/ref-firebase-actions
RobertGemmaJr Apr 4, 2024
580533d
Merge pull request #442 from brown-ccv/feat-prop-validation
RobertGemmaJr Apr 4, 2024
8f12976
Merge branch 'feat-v3.4' into chore-inline
RobertGemmaJr Apr 4, 2024
05cd145
ref: Refactor firebase client to be ALL_CAPS
RobertGemmaJr Apr 4, 2024
0442513
chore: lock
RobertGemmaJr Apr 4, 2024
55c0c01
Merge branch 'feat-v3.4' into ref-event-marker
RobertGemmaJr Apr 4, 2024
a05cb54
chore: lock
RobertGemmaJr Apr 4, 2024
aa7e3cc
ref: Refactor to functions and add docstrings
RobertGemmaJr Apr 4, 2024
a2a49e5
ref: move SerialPort code into its own file
RobertGemmaJr Apr 4, 2024
736bdcd
Merge pull request #454 from brown-ccv/ref-firebase
RobertGemmaJr Apr 5, 2024
186acbe
Merge branch 'main' into feat-v3.4
RobertGemmaJr Apr 5, 2024
42a03e3
Merge branch 'feat-v3.4' into chore-inline
RobertGemmaJr Apr 5, 2024
91c61e9
Merge branch 'feat-v3.4' into ref-event-marker
RobertGemmaJr Apr 5, 2024
f6dd934
Apply suggestions from code review
RobertGemmaJr Apr 5, 2024
5038614
chore: not a real commit
RobertGemmaJr Apr 5, 2024
8b6903d
chore: not a real commit
RobertGemmaJr Apr 5, 2024
bbd3773
Merge pull request #447 from brown-ccv/chore-inline
RobertGemmaJr Apr 5, 2024
39e878c
Merge branch 'main' into feat-v3.4
RobertGemmaJr Apr 5, 2024
0305a70
Merge branch 'feat-v3.4' into ref-event-marker
RobertGemmaJr Apr 5, 2024
4259919
ref: Install Python 3.12 on Windows
RobertGemmaJr Apr 5, 2024
5b6f291
fix: Use module.exports instead of inline export
RobertGemmaJr Apr 5, 2024
cae3d92
Merge pull request #455 from brown-ccv/ref-event-marker
RobertGemmaJr Apr 8, 2024
fcb264a
chore: lock
RobertGemmaJr Apr 8, 2024
8fc1ee2
chore: format
RobertGemmaJr Apr 8, 2024
4468b87
Update public/electron/serialPort.js
RobertGemmaJr Apr 19, 2024
2d5e4a1
Update public/electron/main.js
RobertGemmaJr Apr 19, 2024
7285299
build: Update minor version of node
RobertGemmaJr Apr 19, 2024
0d449a1
build: Deps upgrades
RobertGemmaJr Apr 19, 2024
053012e
Update public/electron/serialPort.js
RobertGemmaJr May 2, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ module.exports = {
plugins: ["react"],
rules: {
"no-unused-vars": "warn",
"react/prop-types": "off", // TODO @brown-ccv #223: App prop validation, remove this rule
"import/order": "warn",
},
settings: {
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/firebase-hosting-merge.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ jobs:
build_and_deploy:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- run: npm install && npm run build:firebase
- uses: actions/checkout@v4
- run: npm ci && npm run build:firebase
- uses: FirebaseExtended/action-hosting-deploy@v0
with:
repoToken: "${{ secrets.GITHUB_TOKEN }}"
Expand Down
8 changes: 6 additions & 2 deletions .github/workflows/firebase-hosting-pull-request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,17 @@

name: Deploy to Firebase Hosting on PR
"on": pull_request
permissions:
checks: write
contents: read
pull-requests: write
jobs:
build_and_preview:
if: "${{ github.event.pull_request.head.repo.full_name == github.repository }}"
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- run: npm install && npm run build:firebase
- uses: actions/checkout@v4
- run: npm ci && npm run build:firebase
- uses: FirebaseExtended/action-hosting-deploy@v0
with:
repoToken: "${{ secrets.GITHUB_TOKEN }}"
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v18.20.0
v20.12.2
1 change: 0 additions & 1 deletion Brewfile
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
# Brewfile for installing Honeycomb prerequisites
# Visit https://brown-ccv.github.io/honeycomb-docs/docs/quick_start for info

brew "git"
cask "github"
brew "openjdk" # NOTE @brown-ccv: This will install Python as a dependency
Expand Down
1 change: 0 additions & 1 deletion env/.env.clinic
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
IMAGE_INLINE_SIZE_LIMIT=0
REACT_APP_USE_EEG="true"
REACT_APP_USE_PHOTODIODE="true"
REACT_APP_VOLUME="true"
12 changes: 6 additions & 6 deletions env/.env.firebase
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
REACT_APP_FIREBASE="true"
REACT_APP_apiKey="AIzaSyB6C2nVXk__dqxdyyROFEC-ue50O_OsjTE"
REACT_APP_authDomain="ccv-honeycomb.firebaseapp.com"
REACT_APP_projectId="ccv-honeycomb"
REACT_APP_storageBucket="ccv-honeycomb.appspot.com"
REACT_APP_messagingSenderId="449496296276"
REACT_APP_appId="1:449496296276:web:0479c82b8b068ca9e6b6c1"
REACT_APP_API_KEY="AIzaSyB6C2nVXk__dqxdyyROFEC-ue50O_OsjTE"
REACT_APP_AUTH_DOMAIN="ccv-honeycomb.firebaseapp.com"
REACT_APP_PROJECT_ID="ccv-honeycomb"
REACT_APP_STORAGE_BUCKET="ccv-honeycomb.appspot.com"
REACT_APP_MESSAGING_SENDER_ID="449496296276"
REACT_APP_APP_ID="1:449496296276:web:0479c82b8b068ca9e6b6c1"
2 changes: 1 addition & 1 deletion env/.env.home
Original file line number Diff line number Diff line change
@@ -1 +1 @@
IMAGE_INLINE_SIZE_LIMIT=0

2 changes: 1 addition & 1 deletion env/.env.turk-prolific
Original file line number Diff line number Diff line change
@@ -1 +1 @@
IMAGE_INLINE_SIZE_LIMIT=0

1 change: 0 additions & 1 deletion env/.env.video
Original file line number Diff line number Diff line change
@@ -1,2 +1 @@
IMAGE_INLINE_SIZE_LIMIT=0
REACT_APP_VIDEO="true"
Loading
Loading