Skip to content

Commit

Permalink
chore: comments
Browse files Browse the repository at this point in the history
  • Loading branch information
RobertGemmaJr committed Aug 5, 2024
1 parent 28c63be commit 5f54457
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 12 deletions.
8 changes: 0 additions & 8 deletions src/App/App.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -52,14 +52,6 @@ export default function App() {
"Task Settings": SETTINGS,
});

// TEMP: Testing to ensure the config is setup correctly
console.log(
"ENVIRONMENT",
import.meta.env.PACKAGE_NAME,
import.meta.env.PACKAGE_VERSION,
import.meta.env
);

// If on desktop
if (CONFIG.USE_ELECTRON) {
// TODO @brown-ccv #443 : Pass NODE_ENV here as well
Expand Down
1 change: 0 additions & 1 deletion vite.main.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ export default defineConfig((env) =>
lib: {
entry: env.forgeConfigSelf.entry,
fileName: () => "[name].js",
// formats: ["cjs"],
formats: ["es"],
},
rollupOptions: { external },
Expand Down
8 changes: 5 additions & 3 deletions vite.preload.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,14 @@ export default defineConfig((env) =>
// Preload scripts may contain Web assets, so use the `build.rollupOptions.input` instead `build.lib.entry`.
input: env.forgeConfigSelf.entry,
output: {
// format: "cjs", // TODO: Switch to ESM modules
format: "es",
// It should not be split chunks.
inlineDynamicImports: true,
entryFileNames: "[name].js",
chunkFileNames: "[name].js",
// NOTE: The preload script must be built with the .mjs extensions: https://www.electronjs.org/docs/latest/tutorial/esm#esm-preload-scripts-must-have-the-mjs-extension
// entryFileNames: "[name].js",
// chunkFileNames: "[name].js",
entryFileNames: "[name].mjs",
chunkFileNames: "[name].mjs",
assetFileNames: "[name].[ext]",
},
},
Expand Down

0 comments on commit 5f54457

Please sign in to comment.