Skip to content

Commit

Permalink
chore: TODO numbers
Browse files Browse the repository at this point in the history
  • Loading branch information
RobertGemmaJr committed Mar 11, 2024
1 parent 9acc4e3 commit 0e2fdc8
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 8 deletions.
6 changes: 2 additions & 4 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,11 @@ jobs:
name: Package and Upload
runs-on: ${{ matrix.os }}

# Run build script for [home/clinic] in [windows/macOS/ubuntu]+
# TODO @brown-ccv: Split OS as seperate jobs with matrix for just the build environments
# Run build script for [home/clinic] in [windows/macOS/ubuntu]
strategy:
matrix:
setting: [home, clinic]
os: [windows-latest, macOS-latest, ubuntu-latest]
setting: [home, clinic]
fail-fast: true

steps:
Expand Down Expand Up @@ -99,7 +98,6 @@ jobs:
tag: ${{ github.ref }}
repo_token: ${{ secrets.GITHUB_TOKEN }}

# TODO @brown-ccv: This should only run on "latest-release" tag on main
deploy-gh-pages:
name: Deploy to GH Pages
runs-on: ubuntu-latest
Expand Down
7 changes: 3 additions & 4 deletions public/electron/main.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,12 +20,12 @@ log.initialize({ preload: true });
// TODO @brown-ccv #192: Handle data writing to desktop in a utility process?
// TODO @brown-ccv #192: Handle video data writing to desktop in a utility process?
// TODO @brown-ccv #398: Separate log files for each run through?
// TODO @brown-ccv: Use app.getPath('temp') for temporary JSON file
// TODO @brown-ccv #429: Use app.getPath('temp') for temporary JSON file

/************ GLOBALS ***********/

let CONFIG; // Honeycomb configuration object
// TODO @brown-ccv: Rename, this is running in development AND user hit "Continue Anyway"
// TODO @brown-ccv #428: Rename, this is running in development AND user hit "Continue Anyway"
let DEV_MODE; // Whether or not the application is running in dev mode

let TEMP_FILE; // Path to the temporary output file
Expand Down Expand Up @@ -295,8 +295,7 @@ function createWindow() {
// Load app from the local bundle created by the build process
appURL = url.format({
// Moves from path of the electron file (/public/electron/main.js) to build folder (build/index.html)
// TODO @brown-ccv: This means we're using the non-built Electron file?
// TODO @brown-ccv: electron-forge should only be packaging the build folder (package.json needs to point to that file?)
// TODO @brown-ccv #424: electron-forge should only be packaging the build folder (package.json needs to point to that file?)
pathname: path.join(__dirname, "../../build/index.html"),
protocol: "file:",
slashes: true,
Expand Down

0 comments on commit 0e2fdc8

Please sign in to comment.