Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: sort people by team #133

Merged
merged 12 commits into from
Sep 14, 2023
Merged

feat: sort people by team #133

merged 12 commits into from
Sep 14, 2023

Conversation

ashleysyg
Copy link
Member

@ashleysyg ashleysyg commented Aug 24, 2023

This PR adds team sorting to the current alphabetical order of CCV staff.

  • sort by team
  • change accent colors for teams
  • change cards to show subteam and team
  • add scroll up to team description (icon next to subteam)
  • back button from person detail takes you to bottom of About page, but link is to #people (maybe fixed in nuxt3)
  • change info icon to email

@github-actions
Copy link

github-actions bot commented Aug 24, 2023

Visit the preview URL for this PR (updated for commit 3e333c5):

https://qa-ccv-brown-edu--pr133-feat-people-sort-v2nee1ab.web.app

(expires Wed, 20 Sep 2023 17:40:41 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 2def302adddb44a0a1eb29d07c5f8ac902277e8a

@ashleysyg ashleysyg requested review from eldu and hetd54 August 25, 2023 15:33
@ashleysyg ashleysyg marked this pull request as ready for review August 28, 2023 16:25
Copy link
Contributor

@eldu eldu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great !

components/blocks/FilesToCards.vue Outdated Show resolved Hide resolved
@ashleysyg ashleysyg marked this pull request as draft September 6, 2023 15:43
@ashleysyg ashleysyg marked this pull request as ready for review September 13, 2023 17:28
@ashleysyg ashleysyg merged commit ec972a3 into main Sep 14, 2023
2 checks passed
@ashleysyg ashleysyg deleted the feat-people-sort branch September 14, 2023 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants