feat(our-work): dynamic routing for detail pages #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 7d0a4ac): https://qa-ccv-brown-edu--pr132-our-work-detail-498n4g2t.web.app (expires Wed, 13 Sep 2023 17:25:57 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 2def302adddb44a0a1eb29d07c5f8ac902277e8a |
added 13 commits
August 18, 2023 15:40
eldu
requested changes
Aug 28, 2023
There was a problem hiding this comment.
I think this looks good to me. Wondering why we're downgrading the node version in this PR.
Also, since the cards only take up half the page, with the new detail page perhaps we move away from cards and use up the whole page? A the moment, all the descriptions are short so it might be a bit silly, but could still be nice.
hetd54
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.