Feature animation controller #45

kmilo9999 · 2022-04-20T16:21:22Z

This PR Includes:

Camera animation
Slice Animation
Save user session with animation states
Fix record video
Labels reworked

…ash modal window on close event

…wn-ccv/VR-Volumeviewer into feature-animation-controller

…close window

…wn-ccv/VR-Volumeviewer into feature-animation-controller

mirestrepo

This is great a lot of work! My comments are mostly formatting. It would be nice if you can start heading towards smaller PRs, that would make it a bit easier to follow the logic changes as well.

include/UI/UIView.h

include/interaction/ArcBallCamera.h

libs/Texture/Texture.cpp

src/loader/VRDataLoader.cpp

src/render/VolumeRaycastShader.cpp

src/vrapp/VolumeVisualizationApp.cpp

Resources/Models/plane.obj

include/UI/UIView.h

src/render/VolumeRaycastShader.cpp

src/vrapp/VolumeVisualizationApp.cpp

…cript

RobertGemmaJr

Looking good! Lots of good work going on here. I think the main things I've seen are

Delete commented out code
Fix tab indenting
Remove unnecessary extra lines
snake_case vs TitleCase vs camelCase consistency
Lots of if statements that can be consolidated to one line (or 2 without the { } if you prefer
I think a couple comments in places where the code gets super busy would go a long way - Mary pointed out some other ones as well

include/UI/UIView.h

src/vrapp/VRVolumeApp.cpp

src/vrapp/VolumeVisualizationApp.cpp

… renaming variables to camel notation.

Resources/README.md

include/interaction/ArcBallCamera.h

include/render/VolumeRenderer.h

include/vrapp/VolumeVisualizationApp.h

src/vrapp/VolumeVisualizationApp.cpp

…ing files

include/UI/UIView.h

include/interaction/Labels.h

include/interaction/PointOfInterests.h

include/interaction/Simulation.h

src/vrapp/VolumeVisualizationApp.cpp

mcmcgrath13

great progress!! I still see quite a few older unresolved comments from both myself and @RobertGemmaJr

shaders/shader.frag

src/UI/UIView.cpp

src/vrapp/VRVolumeApp.cpp

include/UI/UIView.h

include/interaction/Simulation.h

include/render/VolumeRenderer.h

libs/Model/Model.cpp

libs/UIHelpers/transfer_function_widget.cpp

src/UI/UIView.cpp

mcmcgrath13

A few minor nits and @RobertGemmaJr still has some unresolved comments to look at, but let's get this merged!

src/vrapp/VRVolumeApp.cpp

src/vrapp/VolumeVisualizationApp.cpp

superbuild/CMakeLists.txt

RobertGemmaJr

Looking good! I'd just do a clean sweep of any unresolved convos

mirestrepo

I love the consistency in formatting!

kmilo9999 added 15 commits February 1, 2022 11:46

add camera point of interests feature

bc896e0

add poi to save and load session functionality

ce019e5

more changes on UI control

4cf1ec7

add missed files in the last comment

9142b5f

add camera name edit. fix input text field no input on active. fix cr…

649d5bc

…ash modal window on close event

fix camera ui table selection

60b136e

fix resize window and frame buffer

52bab9b

merge feature-camera-positions to get fix on resize window

aa03f35

adde camera animation. camera zoom is broken

0d7d3c4

add animationdurantion input text

e3559dd

add slice animation and 3d terrain lables

73d6789

add Choreograph to superbuild script

1cc9c27

Merge branch 'feature-animation-controller' of https://github.com/bro…

1ff12e5

…wn-ccv/VR-Volumeviewer into feature-animation-controller

add slice and camera animation. fix animation ui. fix memory leak on …

ddc0572

…close window

Merge branch 'feature-animation-controller' of https://github.com/bro…

986eb4c

…wn-ccv/VR-Volumeviewer into feature-animation-controller

kmilo9999 requested review from mirestrepo, mcmcgrath13 and RobertGemmaJr April 20, 2022 16:21

add copy command to move Resource folder to executable folder

86c62e2

mirestrepo requested changes Apr 20, 2022

View reviewed changes

mcmcgrath13 reviewed Apr 20, 2022

View reviewed changes

add Choreograph folder to be exclude in the clean superbuild folder s…

1e7a79f

…cript

RobertGemmaJr requested changes Apr 21, 2022

View reviewed changes

fix file format and identation. remove comments and unused variables.…

14bb1ec

… renaming variables to camel notation.

RobertGemmaJr self-requested a review April 25, 2022 14:08

RobertGemmaJr requested changes Apr 25, 2022

View reviewed changes

kmilo9999 requested review from mirestrepo and mcmcgrath13 April 26, 2022 14:58

address comments from PR review. Delete comments, unuse code, formatt…

0f54d4e

…ing files

kmilo9999 requested a review from RobertGemmaJr April 26, 2022 17:38

mcmcgrath13 suggested changes Apr 26, 2022

View reviewed changes

remove unsed code. rename variables. add comments.

695d9c3

kmilo9999 requested a review from mcmcgrath13 April 28, 2022 18:40

rename variable. remove unused code

9ac9368

mcmcgrath13 reviewed May 3, 2022

View reviewed changes

shaders/shader.frag Show resolved Hide resolved

src/UI/UIView.cpp Show resolved Hide resolved

src/vrapp/VRVolumeApp.cpp Outdated Show resolved Hide resolved

RobertGemmaJr requested changes May 4, 2022

View reviewed changes

kmilo9999 added 2 commits May 6, 2022 18:08

rename variables. format files

6383728

renamed uiview member variable

2d02f28

kmilo9999 mentioned this pull request May 6, 2022

Go up on transfer function widget #49

Closed

kmilo9999 requested review from mcmcgrath13 and RobertGemmaJr May 6, 2022 22:33

kmilo9999 mentioned this pull request May 9, 2022

Fix volume animation frame rate #50

Open

remove commented code. add notes on code.

5a63ded

mcmcgrath13 reviewed May 9, 2022

View reviewed changes

libs/UIHelpers/transfer_function_widget.cpp Outdated Show resolved Hide resolved

remove uncommented code. reformatted files

f197c5f

mcmcgrath13 reviewed May 9, 2022

View reviewed changes

src/UI/UIView.cpp Outdated Show resolved Hide resolved

mcmcgrath13 approved these changes May 9, 2022

View reviewed changes

RobertGemmaJr approved these changes May 10, 2022

View reviewed changes

remove commeted code.

621bf99

kmilo9999 requested a review from mcmcgrath13 May 10, 2022 16:17

mcmcgrath13 approved these changes May 10, 2022

View reviewed changes

mirestrepo approved these changes May 10, 2022

View reviewed changes

kmilo9999 merged commit 3861253 into master May 10, 2022

kmilo9999 deleted the feature-animation-controller branch May 10, 2022 21:29

kmilo9999 mentioned this pull request May 25, 2022

Camera-slices animation #56

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature animation controller #45

Feature animation controller #45

kmilo9999 commented Apr 20, 2022

mirestrepo left a comment

RobertGemmaJr left a comment •

edited

Loading

mcmcgrath13 left a comment

mcmcgrath13 left a comment

RobertGemmaJr left a comment •

edited

Loading

mirestrepo left a comment

Feature animation controller #45

Feature animation controller #45

Conversation

kmilo9999 commented Apr 20, 2022

mirestrepo left a comment

Choose a reason for hiding this comment

RobertGemmaJr left a comment • edited Loading

Choose a reason for hiding this comment

mcmcgrath13 left a comment

Choose a reason for hiding this comment

mcmcgrath13 left a comment

Choose a reason for hiding this comment

RobertGemmaJr left a comment • edited Loading

Choose a reason for hiding this comment

mirestrepo left a comment

Choose a reason for hiding this comment

RobertGemmaJr left a comment •

edited

Loading

RobertGemmaJr left a comment •

edited

Loading