-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VA/VRS quality measures #1610
Open
phildarnowsky-broad
wants to merge
6
commits into
main
Choose a base branch
from
vrs-quality-measures
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
VA/VRS quality measures #1610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rileyhgrant
approved these changes
Aug 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
phildarnowsky-broad
force-pushed
the
vrs-quality-measures
branch
from
August 15, 2024 16:43
0ec7af6
to
6c5f752
Compare
phildarnowsky-broad
force-pushed
the
vrs-quality-measures
branch
2 times, most recently
from
September 17, 2024 16:54
b4921f8
to
41e50f4
Compare
@rileyhgrant this is ready for another look: it's not so different from the state of the code as of your last review, just some alterations to make this work under the new regime I just merged where VA exome and genome data are separated out. |
rileyhgrant
approved these changes
Sep 19, 2024
resolves #1601 |
phildarnowsky-broad
force-pushed
the
vrs-quality-measures
branch
from
October 1, 2024 17:25
41e50f4
to
aaf676d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the
qualityMeasures
fields that were mistakenly left out of our implementation of VA/VRS.