Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VA/VRS quality measures #1610

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Conversation

phildarnowsky-broad
Copy link
Contributor

@phildarnowsky-broad phildarnowsky-broad commented Aug 14, 2024

This adds the qualityMeasures fields that were mistakenly left out of our implementation of VA/VRS.

@phildarnowsky-broad phildarnowsky-broad changed the title Vrs quality measures VA/VRS quality measures Aug 14, 2024
@phildarnowsky-broad phildarnowsky-broad marked this pull request as ready for review August 14, 2024 21:02
Copy link
Contributor

@rileyhgrant rileyhgrant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@phildarnowsky-broad
Copy link
Contributor Author

@rileyhgrant this is ready for another look: it's not so different from the state of the code as of your last review, just some alterations to make this work under the new regime I just merged where VA exome and genome data are separated out.

@rileyhgrant rileyhgrant self-requested a review September 18, 2024 15:23
@phildarnowsky-broad
Copy link
Contributor Author

resolves #1601

@rileyhgrant rileyhgrant linked an issue Sep 19, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add qualityMeasures to VRS
2 participants