Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IntegrateGQ.sh errors due to presence of variants of just one type #760

Open
wants to merge 19 commits into
base: main
Choose a base branch
from

Conversation

kjaisingh
Copy link
Collaborator

@kjaisingh kjaisingh commented Dec 9, 2024

This PR addresses Issue #759.

Description

Addresses an issue in the IntegrateGQ.sh script where the combination of set -o pipefail and { fgrep ... || true; } patterns could cause pipelines to fail prematurely if no matches were found. By leveraging awk with ARGIND, the script no longer fails silently and continues processing regardless of the SVTYPE makeup of the shard.

Testing

  • This Terra job demonstrates the a run with the previous version of IntegrateGQ.sh, wherein each variant in its depth & PESR VCFs are of type - note that the run fails.
  • This Terra job demonstrates the identical run but with the updated version of IntegrateGQ.sh - note that the run completes successfully.

@kjaisingh kjaisingh added the bug Something isn't working label Dec 9, 2024
@kjaisingh kjaisingh self-assigned this Dec 9, 2024
@kjaisingh kjaisingh linked an issue Dec 9, 2024 that may be closed by this pull request
1 task
@kjaisingh kjaisingh requested a review from mwalker174 January 24, 2025 23:49
@kjaisingh kjaisingh marked this pull request as ready for review January 24, 2025 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IntegrateGQ.sh error trapping doesn't work, causing pipe failures
1 participant