Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WX-926 GCP Batch Backend Executor Test Fix #7588

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

WX-926 GCP Batch Backend Executor Test Fix #7588

wants to merge 3 commits into from

Conversation

dspeck1
Copy link
Collaborator

@dspeck1 dspeck1 commented Nov 25, 2024 •
edited
Loading

Description

Fix the backend executor test by correcting the name of the backend from batch to GCPBATCH. Fix error messages on failed integration tests.

Release Notes Confirmation

CHANGELOG.md

  • I updated CHANGELOG.md in this PR
  • I assert that this change shouldn't be included in CHANGELOG.md because it doesn't impact community users

Terra Release Notes

  • I added a suggested release notes entry in this Jira ticket
  • [ X] I assert that this change doesn't need Jira release notes because it doesn't impact Terra users

@dspeck1 dspeck1 requested a review from a team as a code owner November 25, 2024 19:38
@aednichols aednichols changed the title GCP Batch Backend Executor Test Fix WX-926 GCP Batch Backend Executor Test Fix Nov 26, 2024
@dspeck1 dspeck1 added the Don't Look At Me 🙈 (not yet ready for review) label Jan 17, 2025
@dspeck1
The Google Cloud Batch backend name was changed from batch to GCPBATC…
0c93ca1 
…H midway through the development work and some references were missed. Updates the backend name in tests and documentation. The second set of changes fixes failing tests. GCP Batch error messages can vary and this behavior was also seen in PAPIv2. The expected failure messages are simplified to catch failed jobs.
@dspeck1 dspeck1 force-pushed the gcp-batch-backend-execution-actor-test branch from 3665e59 to 0c93ca1 Compare January 20, 2025 15:25
@dspeck1 dspeck1 added Please re-review now and removed Don't Look At Me 🙈 (not yet ready for review) labels Jan 20, 2025
aednichols
aednichols approved these changes Jan 22, 2025
View reviewed changes
Copy link
Collaborator

@aednichols aednichols left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍

@aednichols aednichols enabled auto-merge (squash) January 22, 2025 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LizBaldo LizBaldo LizBaldo approved these changes

@aednichols aednichols aednichols approved these changes

@mcovarr mcovarr Awaiting requested review from mcovarr

Assignees
No one assigned
Labels
GCP Batch Please re-review now
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dspeck1 @aednichols @LizBaldo