Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CommandLineParserConfig #126

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

magicDGS
Copy link
Contributor

For configuring the behavior of the CommandLineParserclass, a new config interface is included and the CommandLineParserOptions removed. The interface include defaults for all the methods and can be used directly, or a custom implementation that allows to configure using system properties, hard-coded values, etc.

The idea is simple: default methods can be overridden in toolkits to provide their own implementation for (at this moment):

In the future, this might include also other configuration (e.g., special arguments to be allow to change the names and/or hide arguments - solving for example #123 without changing barclay).

@codecov-io
Copy link

Codecov Report

Merging #126 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##             master   #126   +/-   ##
=======================================
  Coverage        76%    76%           
- Complexity      591    592    +1     
=======================================
  Files            22     22           
  Lines          2205   2205           
  Branches        456    456           
=======================================
  Hits           1676   1676           
  Misses          352    352           
  Partials        177    177
Impacted Files Coverage Δ Complexity Δ
...e/barclay/argparser/CommandLineArgumentParser.java 82.75% <100%> (ø) 181 <0> (ø) ⬇️
...ute/barclay/argparser/CommandLineParserConfig.java 100% <100%> (ø) 2 <2> (?)
...titute/barclay/help/DefaultDocWorkUnitHandler.java 71.91% <100%> (ø) 75 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21b13d2...210dc61. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants