Set DefaultSortingOption to SortingOption.Views

brminnick · Mar 16, 2020 · ca0d19f · ca0d19f
1 parent b2f16d5
commit ca0d19f
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/GitTrends.Shared/Constants/SortingConstants.cs b/GitTrends.Shared/Constants/SortingConstants.cs
@@ -5,7 +5,7 @@ namespace GitTrends.Shared
 {
     class SortingConstants
     {
-        public const SortingOption DefaultSortingOption = SortingOption.Stars;
+        public const SortingOption DefaultSortingOption = SortingOption.Views;
 
         readonly static Lazy<Dictionary<SortingOption, string>> _sortingOptionsDictionaryHolder = new Lazy<Dictionary<SortingOption, string>>(CreateSortingDictionary);
 

diff --git a/GitTrends.UITests/Tests/RepositoriesTests.cs b/GitTrends.UITests/Tests/RepositoriesTests.cs
@@ -42,7 +42,7 @@ public void VerifySortingOptions(SortingOption sortingOption)
             finalTopRepository = RepositoryPage.GetVisibleRepositoryList().First();
             finalSecondTopRepository = RepositoryPage.GetVisibleRepositoryList().Skip(1).First();
 
-            Assert.GreaterOrEqual(initialTopRepository.StarCount, initialSecondTopRepository.StarCount);
+            Assert.GreaterOrEqual(initialTopRepository.TotalViews, initialSecondTopRepository.TotalViews);
 
             Assert.AreNotEqual(initialTopRepository, finalTopRepository);
             Assert.AreNotEqual(initialSecondTopRepository, finalSecondTopRepository);
@@ -52,7 +52,7 @@ public void VerifySortingOptions(SortingOption sortingOption)
             switch (sortingOption)
             {
                 case SortingOption.Stars:
-                    Assert.LessOrEqual(finalTopRepository.StarCount, finalSecondTopRepository.StarCount);
+                    Assert.GreaterOrEqual(finalTopRepository.StarCount, finalSecondTopRepository.StarCount);
                     break;
                 case SortingOption.Clones:
                     Assert.GreaterOrEqual(finalTopRepository.TotalClones, finalSecondTopRepository.TotalClones);
@@ -70,7 +70,7 @@ public void VerifySortingOptions(SortingOption sortingOption)
                     Assert.GreaterOrEqual(finalTopRepository.TotalUniqueViews, finalSecondTopRepository.TotalUniqueViews);
                     break;
                 case SortingOption.Views:
-                    Assert.GreaterOrEqual(finalTopRepository.TotalViews, finalSecondTopRepository.TotalViews);
+                    Assert.LessOrEqual(finalTopRepository.TotalViews, finalSecondTopRepository.TotalViews);
                     break;
                 default:
                     throw new NotSupportedException();

diff --git a/GitTrends/ViewModels/RepositoryViewModel.cs b/GitTrends/ViewModels/RepositoryViewModel.cs
@@ -77,6 +77,8 @@ async Task ExecutePullToRefreshCommand(string repositoryOwner)
         {
             const int repositoriesPerFetch = 100;
 
+            AnalyticsService.Track("Refresh Triggered", "Sorting Option", _sortingService.CurrentOption.ToString());
+
             try
             {
                 await foreach (var retrievedRepositories in _gitHubGraphQLApiService.GetRepositories(repositoryOwner, repositoriesPerFetch).ConfigureAwait(false))