Gen2024 address compiler warnings #17
Open
+71
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We needed to pass `iH2shieldcustom` and `f_shield_custom` as arguments to `lookup_cool_rates1d_g`. These variables already had type declarations within `lookup_cool_rates1d_g`, but they because they were passed as part of the argument list, they were previously locally allocated within the function and used without initialization. This is all fixed now
Cells at low temperatures previously exceeded the iteration limit. This change should ensure that the tests produce consistent results.
Add logic to initialize itmask_tmp when primordial_chemistry==0. The need for doing this was identified from running cooling_cell.py
A handful of c functions had a `[-Wreturn-type]` compiler warning where a function was supposed to return a value but had at least 1 control flow branch where we didn't return anything. Also fixed a spot in `c_local_example` where we were passing a `chemistry_data**` ptr to `local_free_chemistry_data` rather than a `chemistry_data*` ptr.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This needs to be reviewed after #13 (which had resolved the flaking tests in the test-suite)
This PR consists of 2 commits and addresses some compiler warnings:
cool1D_cloudy_old_tables_g[-Wreturn-type]compiler warning where a function was supposed to return a value but had at least 1 control flow branch where we didn't return anything.c_local_examplewhere we were passing achemistry_data**ptr tolocal_free_chemistry_datarather than achemistry_data*ptr.I have manually confirmed that all tests pass when we include these changes