-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi contig implementation #9
Open
JFsanchezherrero
wants to merge
25
commits into
brinkmanlab:master
Choose a base branch
from
HCGB-IGTP:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ak the trunc() function
Incorporate fix for cross origin genes crashing islandpath.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear developers,
I forked the master version of IslandPath-DIMOB (commit: 34aad6c), then merge the gff branch commit (c24711b) and add additional features.
I implemented multi-contig analysis, following your criteria and using the same functions. I only took into account that the dinuc island and dimob island generated was within the same contig.
In order to implement I had to do some modifications:
Change :
Fix some bugs:
Change input:
I increased the input that were set as fixed variables in the code.
For example, users can supply the minimun number of genes under a dinuc bias (Default 8) or the minimun GI size (Defaulta 8000).
Change output:
Add example:
I have added again the examples files you previously discarded in order to have some sets to rely on. I could always retrieved the same results using the version and the original code.
I tested the multi-contig feature behaviour with some assembly drafts I have here in genbank format and it worked for me. I can not deliver the data due to confidential issues but it might be appropiate to include some available on NCBI genomes for testing purposes. I downloaded and tested a genome of S. aureus (E.g. https://www.ncbi.nlm.nih.gov/assembly/GCA_900457655.1) containing several contig/scaffolds in genbank format (gbf) that I have also included in the example folder.
I hope you find useful this new implementation. If you think it might be appropiate to pull the request do it, if not, that is fine. I would be using this new implementation within my own pipeline, citing you accordingly.
Thank you very much
Please contact me if any further details are necessary