-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Session List #3132
Session List #3132
Conversation
This reverts commit d14fd4d.
This comment was marked as resolved.
This comment was marked as resolved.
I'm currently testing this branch at commit 0babafa. This is a fairly small thing I noticed during testing. It's not the easiest to trigger, but the attached video and steps below seem to trigger it reliably.
An empty slot is left behind for the deleted tab. This empty slot is filled in as soon as I click another tab. I'm guessing we'd have wanted the tab slots to tighten up as soon as the Session was deleted. Repro.mp4 |
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've verified the fix of two issues I previously reported on this branch and haven't noticed any new problems, so I'm 👍 on it. @jameskerr and I discussed offline that the "tab bug" described in #3132 (comment) will be addressed in a follow-on PR after this one merges.
Added a sessions pane in the left sidebar.
Whenever a new query tab is created, a new entry will be added to the list of sessions. When the tab is closed, the session entry will remain. When the session is clicked, it will either activate the associated tab if it exists, or it will restore that tab, along with it's history. You can right click a session to delete it. Deleting it will destroy the associated tab and history.
The display name of the tab is text of the most recent query in that sessions history.
Fixes #2746
Closes #2467