Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't remove \x7f but convert to newline #265

Closed
wants to merge 1 commit into from

Conversation

ccomb
Copy link
Contributor

@ccomb ccomb commented Aug 2, 2024

The comments in a simapro csv files contain several sentences separated with \x7f
This character is removed during import and the comment are not well separated.
I guess this char can be converted to a newline. This allows to then convert it easily to a <br/> in an HTML output.

As an example here is a comment :

Comment: Included processes: The inventory includes : undefined Cut-off rule, exclusion : undefined Remark: Functional unit:Produce 268 t of kiwifruits during 19 years on 1 Ha Academic publications and agricultural publications ILCD � Overall data quality : Technological representativeness (TeR) = undefined Geographical representativeness (GR) = undefined

There is no wy to separate the elements. By keeping a separator it can then be displayed as :

Comment:
Included processes: 
The inventory includes : undefined
Cut-off rule, exclusion : undefined 
Remark: 
Functional unit:Produce 268 t of kiwifruits during 19 years on 1 Ha 
Academic publications and agricultural publications ILCD � 
Overall data quality : Technological representativeness (TeR) = undefined 
Geographical representativeness (GR) = undefined

@cmutel
Copy link
Member

cmutel commented Aug 2, 2024

SimaPro extraction has shifted to https://github.com/brightway-lca/bw_simapro_csv, which treats \x7f correctly.

@cmutel cmutel closed this Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants