Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ContextPath Prefixed for multiple calls via $.ajax/.getJson & more #65

Closed

Conversation

friendlymahi
Copy link

@friendlymahi
Copy link
Author

@hngrylobster - Requesting you to review these changes and advise for any addl fixes. We recently upgraded our AEM to v6.5 SP17 and long due on upgrading Brightcove. With this fix we'll be clean without having to make any changes on clientlibs and manage your code copy on our end.

Thanks in advance !

@friendlymahi
Copy link
Author

@hngrylobster - Happy New Year ! We wanted to know if you intend to review and advise on these fixes so we can communicate to our leadership team on the next upgrade/version bump of brightcove in our org. Thanks !!

@dcolvinbc
Copy link
Collaborator

@friendlymahi I asked a question on this to possibly resolve. Also if this is for on prem please cancel this pr do changes on your own branch from release/6.0.5 and do your pr to merge into this branch. If clould do the changes from release/6.1.2-cloud. We will be working on combining these branches in the future so that one single master will work. Thank you

@friendlymahi
Copy link
Author

@dcolvinbc - sure. Will send a new pr as this is for onprem. Also shall I send the PR back to release/6.0.5 itself or master? !

@dcolvin
Copy link

dcolvin commented Feb 14, 2024

The PR should be to merge to release/6.0.5.

@friendlymahi
Copy link
Author

Thanks again for taking time to respond. I will send a PR today.

@friendlymahi
Copy link
Author

Closing this PR in favor of the new one.
#66

Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants