fix(secrets): omit all secrets value in line #6802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achiar99
requested a deployment
to
scan-security
GitHub Actions
Waiting
achiar99
changed the title
achiar99
requested a deployment
to
scan-security
GitHub Actions
Waiting
achiar99
requested a deployment
to
scan-security
GitHub Actions
Waiting
pazbechor
approved these changes
Oct 29, 2024
achiar99
requested a deployment
to
scan-security
GitHub Actions
Waiting
omryMen
approved these changes
Oct 30, 2024
achiar99
temporarily deployed
to
scan-security
GitHub Actions
Inactive
Saarett
pushed a commit
to alanszlosek/checkov
that referenced
this pull request
Oct 30, 2024
* omit all secrets value in line * lint * add test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User description
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
If there are more than one secrets in one line - omit all the values
New/Edited policies (Delete if not relevant)
Description
Include a description of what makes it a violation and any relevant external links.
Fix
How does someone fix the issue in code and/or in runtime?
Checklist:
Generated description
Dear maintainer, below is a concise technical summary of the changes proposed in this PR:
Enhance the
Runnerclass incheckov/secrets/runner.pyto handle multiple secrets on a single line by omitting all secret values. Introduce a new data structure to map secrets by line and update the logic to censor each secret value. Add a test case intests/secrets/test_runner.pyto verify the functionality with a sample input filemultiple_secrets_one_line.txt.Modified files (2)
Latest Contributors(2)
Runnerclass to handle multiple secrets on a single line by omitting all secret values.Modified files (1)
Latest Contributors(2)