Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(arm): add variable and parameters edges and rendering #6787

Merged
merged 15 commits into from
Oct 22, 2024

Conversation

lirshindalman
Copy link
Contributor

@lirshindalman lirshindalman commented Oct 22, 2024

User description

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

New/Edited policies (Delete if not relevant)

Description

Include a description of what makes it a violation and any relevant external links.

Fix

How does someone fix the issue in code and/or in runtime?

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes

Generated description

Dear maintainer, below is a concise technical summary of the changes proposed in this PR:

Introduce variable and parameter edge rendering in the ARM graph builder. Enhance the ArmLocalGraph class to support variable vertices creation and edge rendering between variables and parameters. Implement the ArmVariableRenderer class to handle variable rendering logic. Update tests to validate the new functionality, ensuring that vertices and edges are correctly created and rendered.

TopicDetails
Utility Refactor Refactor and move the adjust_value function to a common utility module.
Modified files (4)
  • checkov/bicep/utils.py
  • checkov/bicep/graph_builder/variable_rendering/renderer.py
  • checkov/common/graph/graph_builder/utils.py
  • checkov/bicep/graph_builder/local_graph.py
Latest Contributors(2)
EmailCommitDate
[email protected]break-general-remove-P...October 04, 2023
57212002+ChanochShayne...fix-terraform-Not-addi...November 15, 2022
Variable Rendering Add support for variable vertices and edges in the ARM graph builder.
Modified files (4)
  • tests/arm/graph_builder/test_local_graph.py
  • tests/arm/rendering/test_rendering.py
  • checkov/arm/graph_builder/local_graph.py
  • checkov/arm/graph_builder/variable_rendering/renderer.py
Latest Contributors(1)
EmailCommitDate
[email protected]fix-arm-correctly-hand...August 30, 2023
Test Enhancements Update tests to validate the new variable rendering functionality in ARM.
Modified files (3)
  • tests/arm/rendering/test_rendering.py
  • tests/arm/test_graph_manager.py
  • tests/arm/rendering/test_rendering.json
Latest Contributors(2)
EmailCommitDate
49649760+lirshindalman...platform-general-remov...January 28, 2024
[email protected]fix-arm-correctly-hand...August 30, 2023
This pull request is reviewed by Baz. Join @lirshindalman and the rest of your team on (Baz).

@lirshindalman lirshindalman changed the title feat(arm): vars and parameters edges feat(arm): variable and parameters edges and rendering Oct 22, 2024
@lirshindalman lirshindalman changed the title feat(arm): variable and parameters edges and rendering feat(arm): add variable and parameters edges and rendering Oct 22, 2024
checkov/arm/graph_builder/local_graph.py Outdated Show resolved Hide resolved
checkov/arm/graph_builder/local_graph.py Outdated Show resolved Hide resolved
@lirshindalman lirshindalman merged commit e2fa39d into main Oct 22, 2024
40 of 42 checks passed
@lirshindalman lirshindalman deleted the add_variable_randering_to_arm branch October 22, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants