Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(helm): Remove helm target dir after scanning #6767

Merged
merged 3 commits into from
Oct 14, 2024

Conversation

rotemavni
Copy link
Collaborator

@rotemavni rotemavni commented Oct 12, 2024

User description

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

New/Edited policies (Delete if not relevant)

Description

Include a description of what makes it a violation and any relevant external links.

Fix

How does someone fix the issue in code and/or in runtime?

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes

Generated description

Dear maintainer, below is a concise technical summary of the changes proposed in this PR:

Introduce a method remove_target_folder in the Runner class to clean up the Helm target directory after scanning. This method uses shutil.rmtree to delete the directory and logs any errors encountered during the process. Integrate this cleanup step into the run method to ensure the target folder is removed post-execution.

TopicDetails
Run Method Update Integrate the remove_target_folder method into the run method of the Runner class to ensure the Helm target directory is removed after the scanning process is complete.
Modified files (1)
  • checkov/helm/runner.py
Latest Contributors(2)
EmailCommitDate
[email protected]feat-general-add-possi...November 12, 2023
[email protected]...fix-helm-Changed-error...August 31, 2023
Helm Target Cleanup Implement a cleanup process for the Helm target directory by adding a new method remove_target_folder in the Runner class. This method uses shutil.rmtree to delete the directory and logs any errors encountered during the process.
Modified files (1)
  • checkov/helm/runner.py
Latest Contributors(2)
EmailCommitDate
[email protected]feat-general-add-possi...November 12, 2023
[email protected]...fix-helm-Changed-error...August 31, 2023
This pull request is reviewed by Baz. Join @rotemavni and the rest of your team on (Baz).

@rotemavni rotemavni marked this pull request as ready for review October 13, 2024 06:10
@rotemavni rotemavni merged commit f2527ce into main Oct 14, 2024
42 checks passed
@rotemavni rotemavni deleted the remove-helm-local-folder branch October 14, 2024 16:52
Ali-Razmjoo pushed a commit to fork-the-planet/checkov that referenced this pull request Oct 15, 2024
* remove helm target dir after scanning

* blank line at the end of file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants