Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(general): Adds GHA support for skip-frameworks, skip-cve-package & output-bc-ids flags #5619

Merged
merged 7 commits into from
Oct 22, 2023

Conversation

billyjbryant
Copy link
Contributor

@billyjbryant billyjbryant commented Oct 5, 2023

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

Added support for the following flags through github actions:

  • skip-framework
  • skip-cve-package
  • output-bc-ids

Motivation

Our organization is using Github actions to run checkov scans and would like to implement these flags using the official action instead of installing and running checkov in a step.

Related

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@billyjbryant billyjbryant changed the title feat(general): Adds support for openai-api-key, skip-frameworks, skip-cve-package & output_bc_ids flags feat(general): Adds support for openai-api-key, skip-frameworks, skip-cve-package & output-bc-ids flags Oct 5, 2023
@billyjbryant billyjbryant changed the title feat(general): Adds support for openai-api-key, skip-frameworks, skip-cve-package & output-bc-ids flags feat(general): Adds GHA support for openai-api-key, skip-frameworks, skip-cve-package & output-bc-ids flags Oct 5, 2023
@billyjbryant billyjbryant temporarily deployed to scan-security October 5, 2023 16:16 — with GitHub Actions Inactive
Copy link
Contributor

@gruebel gruebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, except what is written in my comment 🏅

github_action_resources/entrypoint.sh Outdated Show resolved Hide resolved
@billyjbryant billyjbryant temporarily deployed to scan-security October 20, 2023 18:54 — with GitHub Actions Inactive
@billyjbryant billyjbryant changed the title feat(general): Adds GHA support for openai-api-key, skip-frameworks, skip-cve-package & output-bc-ids flags feat(general): Adds GHA flag support for skip-frameworks, skip-cve-package & output-bc-ids flags Oct 20, 2023
@billyjbryant billyjbryant changed the title feat(general): Adds GHA flag support for skip-frameworks, skip-cve-package & output-bc-ids flags feat(general): Adds GHA support for skip-frameworks, skip-cve-package & output-bc-ids flags Oct 20, 2023
@billyjbryant billyjbryant requested a review from gruebel October 20, 2023 18:56
Copy link
Contributor

@gruebel gruebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for both PRs 🏆

@gruebel gruebel merged commit c4831e5 into bridgecrewio:main Oct 22, 2023
32 checks passed
pull bot pushed a commit to tooniez/checkov that referenced this pull request Oct 22, 2023
… & output-bc-ids flags (bridgecrewio#5619)

* Updates flags for Github Actions

Related: bridgecrewio/checkov-action#148

* Adding OpenAI support

* Expanded support for skip-cve-package to accept a comma delimited list

* Removing the open-ai flag
@billyjbryant billyjbryant deleted the billybryant/new-flags branch October 23, 2023 17:15
billyjbryant added a commit to billyjbryant/checkov-action that referenced this pull request Oct 23, 2023
gruebel pushed a commit to bridgecrewio/checkov-action that referenced this pull request Oct 26, 2023
…skip-cve-package & output-bc-ids (#148)

* Updates flags for Github Actions

Adds: skip-framework, output_bc_ids, skip_cve_package

* Adds OpenAi Support

Update Docs

* Removing openai_api_key flag support per request in bridgecrewio/checkov#5619
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants