Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add configurable support for both raw and base64 uploads #109

Merged
merged 4 commits into from
Oct 8, 2023

Conversation

briantist
Copy link
Owner

Fixes #105

@briantist briantist added bug Something isn't working enhancement New feature or request labels Oct 8, 2023
@briantist briantist added this to the v0.11.0 milestone Oct 8, 2023
@briantist briantist self-assigned this Oct 8, 2023
@codecov
Copy link

codecov bot commented Oct 8, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (1c706dd) 61.58% compared to head (ed5793f) 62.60%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #109      +/-   ##
==========================================
+ Coverage   61.58%   62.60%   +1.02%     
==========================================
  Files          32       33       +1     
  Lines        1463     1511      +48     
==========================================
+ Hits          901      946      +45     
- Misses        562      565       +3     
Files Coverage Δ
galactory/utilities.py 44.52% <100.00%> (+7.31%) ⬆️
tests/unit/conftest.py 92.85% <100.00%> (+0.06%) ⬆️
.../unit/utilities/test_incoming_collection_stream.py 100.00% <100.00%> (ø)
galactory/__init__.py 31.25% <0.00%> (-0.33%) ⬇️
galactory/api/v2/collections.py 18.48% <0.00%> (-0.85%) ⬇️
galactory/api/v3/collections.py 23.25% <0.00%> (-0.78%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@briantist briantist marked this pull request as ready for review October 8, 2023 20:47
@briantist briantist merged commit baac25c into main Oct 8, 2023
11 checks passed
@briantist briantist deleted the publish/base64-raw branch October 8, 2023 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Collection publishing doesn't work if the tarball is not base64 encoded
1 participant