-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add galaxy v3 support, refactor, other fixes #104
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, fix collection URLs
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #104 +/- ##
==========================================
+ Coverage 56.77% 61.58% +4.81%
==========================================
Files 27 32 +5
Lines 1011 1463 +452
==========================================
+ Hits 574 901 +327
- Misses 437 562 +125
☔ View full report in Codecov by Sentry. |
briantist
added
bug
Something isn't working
enhancement
New feature or request
dependencies
Pull requests that update a dependency file
python
Pull requests that update Python code
labels
Oct 8, 2023
This was referenced Oct 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
dependencies
Pull requests that update a dependency file
enhancement
New feature or request
python
Pull requests that update Python code
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #102
Related #99 (as of this PR we now override proxied requests to always request 100 results, but we still don't support true pagination).
Fixes #23
Fixes #103
Fixes #100
Large PR to add galaxy v3 support.
There's a bunch of other small fixes, enhancements, and changes here too.
There's a fair amount of refactoring. I wanted to do even more, and maybe come up with a more generalized view system so there won't be so much repetition between v2 and v3 but it was taking too long, and I need to get working v3 support out with the public galaxy switchover, so maybe that will happen another time.
This will add support both for serving over v3 and proxying upstream v3.
Proxying requests from v2 API client calls to upstream v3 or vice-versa is not supported. No translation will be done; the client request's API version must be supported by the upstream you choose.
This should end up ok because galaxy v3 is supported all the way back to
ansible-galaxy
in 2.9. I don't think I'll ever implement proxy translation, but possible ways to do that:ansible-core
and using its galaxy client (not supported, probably not a good idea); I'm not sure if it would actually be useful or provide the right methods eitherantsibull-core
and using its custom galaxy client, but it's all async and galactory is not (yet) which makes it kind of a pain to use; even still I'm not sure if provides the right methods