Rebase verify_cert: check name constraints after sig. validation #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cpu See the last commit about the semver breakage in rcgen. |
Codecov Report
@@ Coverage Diff @@
## main #280 +/- ##
==========================================
+ Coverage 50.62% 51.18% +0.55%
==========================================
Files 18 18
Lines 3751 3806 +55
==========================================
+ Hits 1899 1948 +49
- Misses 1852 1858 +6
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
briansmith
force-pushed
the
backport-name-constraints-post-sigs
branch
from
ac5c13b
to
a7a0d41
Compare
Prior to this commit parsing and processing certificate name constraints was done before validating a chain of signatures to a known trust anchor. This increases the attack surface of these features, allowing an adversary to force webpki to process name constraints on a crafted certificate without needing to have that certificate issued by a trusted entity. This commit moves the parsing and processing of name constraints to after building and verifying the chain of signatures to reduce the potential for mischief.
briansmith
force-pushed
the
backport-name-constraints-post-sigs
branch
from
a7a0d41
to
ed2ac06
Compare
Thanks, I fixed that upstream but it's pending release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebase #278 on top of main after #277 was merged.