marginal speed improvement, re. #37

brianmhunt · Dec 24, 2015 · 00e0340 · 00e0340
1 parent 7b3c9ac
commit 00e0340
Show file tree

Hide file tree

Showing 4 changed files with 22 additions and 14 deletions.
diff --git a/dist/knockout-fast-foreach.js b/dist/knockout-fast-foreach.js
@@ -1,5 +1,5 @@
 /*!
-  Knockout Fast Foreach v0.6.0 (2015-12-17T02:29:56.923Z)
+  Knockout Fast Foreach v0.6.0 (2015-12-24T03:08:52.576Z)
   By: Brian M Hunt (C) 2015 | License: MIT
 
   Adds `fastForEach` to `ko.bindingHandlers`.
@@ -367,12 +367,14 @@ FastForEach.prototype.deleted = function (changeItem) {
 
 // removes a set of nodes from the DOM
 FastForEach.prototype.removeNodes = function (nodes) {
-  if (!nodes.length) {
-    return;
-  }
+  if (!nodes.length) { return; }
 
   var removeFn = function () {
-    ko.utils.arrayForEach(nodes, function (n) { ko.removeNode(n); });
+    var parent = nodes[0].parentNode;
+    for (var i = nodes.length - 1; i >= 0; --i) {
+      ko.cleanNode(nodes[i]);
+      parent.removeChild(nodes[i]);
+    }
   };
 
   if (this.beforeRemove) {

diff --git a/dist/knockout-fast-foreach.min.js b/dist/knockout-fast-foreach.min.js
diff --git a/gulpfile.js b/gulpfile.js
@@ -7,10 +7,10 @@
 
  */
 var gulp = require('gulp'),
-    yaml = require('js-yaml'),
-    fs = require('fs'),
-    config = yaml.safeLoad(fs.readFileSync('./config.yaml', 'utf8')),
-    plugins = require('gulp-load-plugins')();
+  yaml = require('js-yaml'),
+  fs = require('fs'),
+  config = yaml.safeLoad(fs.readFileSync('./config.yaml', 'utf8')),
+  plugins = require('gulp-load-plugins')();
 
 // from https://github.com/ikari-pl/gulp-tag-version
 // function inc(importance) {
@@ -41,4 +41,8 @@ gulp.task('js', function () {
     .pipe(gulp.dest('./dist'));
 });
 
+gulp.task('watch', function () {
+  gulp.watch('./index.js', ['js'])
+})
+
 gulp.task('default', ['js'])
diff --git a/index.js b/index.js
@@ -351,12 +351,14 @@ FastForEach.prototype.deleted = function (changeItem) {
 
 // removes a set of nodes from the DOM
 FastForEach.prototype.removeNodes = function (nodes) {
-  if (!nodes.length) {
-    return;
-  }
+  if (!nodes.length) { return; }
 
   var removeFn = function () {
-    ko.utils.arrayForEach(nodes, function (n) { ko.removeNode(n); });
+    var parent = nodes[0].parentNode;
+    for (var i = nodes.length - 1; i >= 0; --i) {
+      ko.cleanNode(nodes[i]);
+      parent.removeChild(nodes[i]);
+    }
   };
 
   if (this.beforeRemove) {