Fix communication failures with aws-secretsmanager-jdbc #1932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using aws-secretsmanager-jdbc with HikariCP triggers sporadic communication link failures with MySQL. aws-secretsmanager-jdbc library provides JDBC drivers to retrieve DB credentials, host and password from the Amazon Secrets Manager. See: - https://docs.aws.amazon.com/secretsmanager/latest/userguide/retrieving-secrets_jdbc.html - https://github.com/aws/aws-secretsmanager-jdbc By specifying the secret id as a JDBC an URL, and com.amazonaws.secretsmanager.sql.AWSSecretsManagerMySQLDriver as JDBC driver, HikariCP can connect to the MySQL endpoint. But in this stituation, communication link failures occur: com.mysql.cj.jdbc.exceptions.CommunicationsException: Communications link failure The last packet successfully received from the server was 5,006 milliseconds ago. The last packet sent successfully to the server was 5,007 milliseconds ago. These failures are due a MySQL bug: http://bugs.mysql.com/bug.php?id=75615 which is bypassed by HikariCP when the MySQL driver is used. See: - brettwooldridge#236 - 8af2bc5 (Fix brettwooldridge#236 via workaround for MySQL issue http://bugs.mysql.com/bug.php?id=75615, 2015-01-24) This commit applies the same hack for AWSSecretsManagerMySQLDriver.
gontard
force-pushed
the
mysql-75615-workaround
branch
from
b027d98
to
334a93c
Compare
lfbayer
reviewed
Sep 27, 2022
| { | ||
| // Temporary hack for MySQL issue: http://bugs.mysql.com/bug.php?id=75615 | ||
| if ((dsClassName != null && dsClassName.contains("Mysql")) || | ||
| (jdbcUrl != null && jdbcUrl.contains("mysql")) || | ||
| (dataSource != null && dataSource.getClass().getName().contains("Mysql"))) { | ||
| (dataSource != null && dataSource.getClass().getName().contains("Mysql")) || | ||
| "com.amazonaws.secretsmanager.sql.AWSSecretsManagerMySQLDriver".equals(driverClassName)) { |
There was a problem hiding this comment.
In your case, what is the dataSource classname? Does it contain the name "MySQL", if so the existing contains("Mysql") maybe should just be changed to a case insensitive check.
brettwooldridge
force-pushed
the
dev
branch
2 times, most recently
from
6d319ab
to
7cacd0f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit message.