chore: remove tests for serializer #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Shouldn't we keep the tests of getSerializer even we have replaced ivorySerializer with SymfonySerializer to test the dependency injection stuff working properly? |
|
The tests did compare a SerializerMockup against a real one. |
|
okay, this doesn't make sense anyway ^^ LGTM |
|
We did change a lot of things in the last 2 days. |
|
I'll try to run it on our sf6 project tomorrow 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#21
The failing tests are in my point of view, related to the changes from the migration to the symfony/serializer component and DI. That is hardcodet.
https://github.com/bresam/ivory-google-map-bundle/commits/v6/DependencyInjection/IvoryGoogleMapExtension.php
I did remove the failing tests.
It would be great to habe a real world test with the actual
v6-Branch.