Skip to content

Commit

Permalink
Bump Python version requirement
Browse files Browse the repository at this point in the history
  • Loading branch information
brentyi committed Feb 17, 2024
1 parent 5c01b47 commit 5ebb123
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 6 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
python-version: ["3.7", "3.8", "3.9"]
python-version: ["3.8", "3.9"]

steps:
- uses: actions/checkout@v2
Expand Down
5 changes: 2 additions & 3 deletions jaxfg/core/_factor_base.py
Original file line number Diff line number Diff line change
@@ -1,11 +1,10 @@
import abc
from typing import Generic, Tuple, Type, TypeVar, cast, get_type_hints
from typing import Generic, Tuple, Type, TypeVar, cast, get_args, get_type_hints

import jax
import jax_dataclasses as jdc
from jax import numpy as jnp
from overrides import EnforceOverrides, final
from typing_utils import get_args, issubtype

from .. import hints, noises
from ._variable_assignments import VariableAssignments
Expand Down Expand Up @@ -136,7 +135,7 @@ def build_variable_value_tuple(
) from e

# Function should be hinted with a tuple of some kind, but not `tuple` itself
assert issubtype(value_type, tuple), value_type is not tuple
assert issubclass(value_type, tuple), value_type is not tuple

# Heuristic: evaluates to `True` for NamedTuple types but `False` for
# `Tuple[...]` types. Note that standard superclass checking approaches don't
Expand Down
3 changes: 1 addition & 2 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
license="BSD",
packages=find_packages(),
package_data={"jaxfg": ["py.typed"]},
python_requires=">=3.7",
python_requires=">=3.8",
install_requires=[
"tyro",
"frozendict",
Expand All @@ -22,7 +22,6 @@
"scikit-sparse",
"termcolor",
"tqdm",
"typing_utils", # We can phase this out if we drop support for Python 3.7
"matplotlib",
],
extras_require={
Expand Down

0 comments on commit 5ebb123

Please sign in to comment.