Add pagination to index route #17
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonahroth
force-pushed
the
16-index-route-pagination
branch
from
0222300 to
129cd01
Compare
brendanthomas1
requested changes
Apr 20, 2018
| @@ -1,5 +1,8 @@ | |||
| source 'https://rubygems.org' | |||
|
|
|||
| # Use kaminari for pagination | |||
| gem 'kaminari' | |||
There was a problem hiding this comment.
Can we remove this from here and add it as a dependency in the .gemspec, please? I think you'll need to add a require 'kaminari' in the engine.rb file too.
This seems to work in the dummy app, but it's not working for me in a separate, external rails app that I'm testing in. That doesn't get kaminari on bundle.
| remote: data-remote | ||
| -%> | ||
| <span class="prev"> | ||
| <%= link_to '<', url, rel: 'prev', remote: remote, class: 'button' %> |
There was a problem hiding this comment.
I'm just trying this out, not a real suggestion
Suggested change
| <%= link_to '<', url, rel: 'prev', remote: remote, class: 'button' %> | |
| <%= link_to '<--', url, rel: 'prev', remote: remote, class: 'button' %> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16
Using Kaminari for pagination with 10 changes per page - let me know if that doesn't seem right!