Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a project I'm working on, we're using sails-mongo for our production database. To keep things as similar as possible for the test suite, I'd like to have string IDs which are effectively ObjectId's.
This didn't work, since the code assumes IDs are auto-increment integers. The code replaced the correct string IDs with
undefined
. The line that does this is:This becomes
that.idMap[associatedModelName][NaN]
, which returnsundefined
. SettingautoAssociations
tofalse
didn't solve this. I've added checks to see whether the ID is an integers (or can be coerced to an integer) before replacing the value of the association.I've also added two new test cases (which can be run using
npm run test:...
) with string IDs which can be coerced to integers and object IDs which can't be coerced.