Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding message type, and making sure message type doesn't get overriden #64

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

EssentialsDev
Copy link

The "html" message type was missing causing "slideup" to get returned.

Also when using the "full" type it would loop thru to the "html_full" and return that since it ends with "full"

@WillNeill
Copy link

Hi @hokstuff, just seeing if this is something you're looking to review and merge anytime soon? Thank

@hokstuff
Copy link
Collaborator

Hi, so I fully understand this proposed change, can you add more context in what the expected behavior is as well as the actual behavior you are seeing? Can you also attach the campaign you are using that you're running into issues with? (If you're more comfortable, feel free to contact [email protected] with the information)

I have some concerns with the code that is added, so I would like to understand the root of the problem and then make the change internally:
Re: This line - Rather than use the endsWith, it probably would be more accurate to compare each string directly

@EssentialsDev
Copy link
Author

@hokstuff the key problem was that our marketing team was using the MessageType.html which isn't supported in the flutter project. The addition of the break was because full and html_full both end in "full" so if you are using the MessageType full it will still iterate thru the for loop and end up changing messageType to html_full when that is not expected.

I tried to make as little of a change as possible let me know if there is anything I should change.

We ended up using parts of the Android library instead, so I apologize for the delay in my response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants