#212 Make the modal scrollable

braxtonhall · Jan 12, 2023 · a657320 · a657320
1 parent 4cb4522
commit a657320
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 6 deletions.
diff --git a/src/sass/modal.sass b/src/sass/modal.sass
@@ -43,6 +43,8 @@ $modal-background-colour: colours.$white
 				margin-bottom: 0
 
 		.better-library-thing-modal-element-container
+			overflow-y: auto
+			max-height: 60vh
 			width: 100%
 			margin-top: 20px
 

diff --git a/src/ts/content/extensions/util/tagValidation/dialogs/insertTags.ts b/src/ts/content/extensions/util/tagValidation/dialogs/insertTags.ts
@@ -49,12 +49,16 @@ const confirm = (tag: string, remainingTags: string[], node: TagRoot | TagTree)
 					colour: UIColour.GREY,
 					onClick: async () => resolve(remainingTags.filter((otherTag) => otherTag !== tag)),
 				},
-				{
-					kind: "button",
-					text: "Deeper",
-					colour: UIColour.BLUE,
-					onClick: async () => resolve(insertTagIntoOneOf(tag, remainingTags, node.children)),
-				},
+				...(node.children.length // TODO this kinda but better and checking for depth
+					? [
+							{
+								kind: "button" as const,
+								text: "Deeper",
+								colour: UIColour.BLUE,
+								onClick: async () => resolve(insertTagIntoOneOf(tag, remainingTags, node.children)),
+							},
+					  ]
+					: []),
 				{kind: "button", text: "Back", colour: UIColour.RED, onClick: async () => resolve(remainingTags)},
 			],
 			colour: UIColour.BLUE,