add timeout to websocket connection and socket heartbeat

[Neelansh-ns]

Add timeout to websocket connection and send socket heartbeat, else in case of no internet, await _ws!.ready is stuck indefinitely. This causes the socket not to try reconnecting while the internet is not present.

A similar case would happen in the previous versions of the library when await _ws!.ready was not added. It gets stuck indefinitely when sending a socket heartbeat.

[RodolfoSilva]

Nice job @Neelansh-ns

I think a better solution would be to expose a method like: reconnect(), to allow the application to handle when the socket should or should not try the connection again. This allows the application to use the connection-plus plugin to check when the connection changes and then try to reconnect.

What do you think @Neelansh-ns @matehat

[Neelansh-ns]

I think a better solution would be to expose a method like: reconnect(), to allow the application to handle when the socket should or should not try the connection again. This allows the application to use the connection-plus plugin to check when the connection changes and then try to reconnect.

The issue this PR would solve is that it is adding a timeout to the ready future await _ws!.ready and similarly for sending the heartbeat. If this won't we there it takes around close 120 to 180 seconds to get a WebSocketException with the error message OS Error Time Out .

On receiving such an error, the _onSocketError callback is triggered which in turn calls _onSocketClosed which tries to reconnect as _shouldReconnect is true.

So the reconnect functionality is there, but it takes a sufficient amount of time awaiting the futures. Hence this PR adds a timeout for that.

I'll try to open a separate PR for the reconnect, which would require some refactoring.

[Neelansh-ns]

@RodolfoSilva did you get a chance to check this?

[matehat]

💯

[matehat]

Nice job @Neelansh-ns

I think a better solution would be to expose a method like: reconnect(), to allow the application to handle when the socket should or should not try the connection again. This allows the application to use the connection-plus plugin to check when the connection changes and then try to reconnect.

What do you think @Neelansh-ns @matehat

As mentioned by @Neelansh-ns, I think this issue is orthogonal to the need for a reconnect() method, which I think is also a good idea!