Await for a successful connection to the websocket before listening to messages #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@matehat the integration sockets tests are failing. I will investigate what's happening there and let you know if I need help with them. |
miguelcmedeiros
commented
Apr 19, 2024
| @@ -508,10 +516,6 @@ class PhoenixSocket { | |||
| void _onSocketData(message) => onSocketDataCallback(message); | |||
|
|
|||
| void _onSocketError(dynamic error, dynamic stacktrace) { | |||
| if (_socketState == SocketState.closing || | |||
There was a problem hiding this comment.
@matehat
While testing the original change, I noticed that this check was preventing the socket from being reconnected, since _onSocketClosed() is called after it. The scheduling of the socket reconnection happens at that point.
Does it make sense?
miguelcmedeiros
commented
Apr 19, 2024
lib/src/socket.dart
Outdated
| @@ -171,7 +171,9 @@ class PhoenixSocket { | |||
| bool get isConnected => _ws != null && _socketState == SocketState.connected; | |||
|
|
|||
| void _connect(Completer<PhoenixSocket?> completer) async { | |||
| if (_ws != null) { | |||
| if (_ws != null && | |||
| (_socketState != SocketState.connected || | |||
There was a problem hiding this comment.
@matehat
In the case of a reconnection, we have a closed socket, then we would not attempt to reconnect.
If the socket state is unknown, closing or closed, then we are able to proceed with the reconnection of the socket.
miguelcmedeiros
force-pushed
the
bugfix/await-socket-connect-ready
branch
from
49c79f9
to
c964569
Compare
miguelcmedeiros
force-pushed
the
bugfix/await-socket-connect-ready
branch
from
c964569
to
be10e08
Compare
|
Great investigation! Thanks @miguelcmedeiros for your work :) |
matehat
approved these changes
Apr 24, 2024
s6o
pushed a commit
to s6o/phoenix-socket-dart
that referenced
this pull request
May 23, 2024
…o messages (braverhealth#76) * Await for a successful connection to the websocket before listening to messages * Fix socket reconnection * Update socket state accordingly and reason about at the beginning of _connect()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to issues (issue 1 and issue 2) reported in web_socket_channel package.
When the websocket connection is created and there's an exception thrown at this point we won't be able to catch it, leaving the client in an unrecoverable state (i.e. since the exception is not caught, the websocket artefacts are not properly cleared up).
socket.readywill complete with an error in case something goes wrong duringWebSocketChannel.connect().It's not an obvious API, but it seems to be the way to go with this package.