Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default.json: use config:best-practices #6

Merged
merged 2 commits into from
Feb 29, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 38 additions & 0 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
name: Validate Renovate Config

on:
push:
branches:
- main
- master
pull_request:
branches:
- main
- master

jobs:
validate:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744 # v3.6.0

- uses: actions/setup-node@60edb5dd545a775178f52524783378180af0d1f8 # v4.0.2
with:
node-version: '20.x'

- name: Validate Renovate config
run: npx --yes --package renovate -- renovate-config-validator default.json

needs_migration:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744 # v3.6.0

- uses: actions/setup-node@60edb5dd545a775178f52524783378180af0d1f8 # v4.0.2
with:
node-version: '20.x'

- name: Validate Renovate config
run: npx --yes --package renovate -- renovate-config-validator --strict default.json
31 changes: 31 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
# Node.js
node_modules/
npm-debug.log
yarn-error.log

# Editors
.idea/
.vscode/
*.swp
*.swo
*.swn
*.bak
*.orig
*.sublime-*
*.iml

# Operating Systems
# macOS
.DS_Store
.AppleDouble
.LSOverride
Icon
._*
.Spotlight-V100
.Trashes
ehthumbs.db
Desktop.ini

# Windows
Thumbs.db
Desktop.ini
3 changes: 1 addition & 2 deletions default.json
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
{
"$schema": "https://docs.renovatebot.com/renovate-schema.json",
"extends": [
"config:base",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is best-practices a super-set of config:base? And if not, what would be removed with this change?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

based on my understanding config:base is the one inherited by every other configuration. We can leave it in, in case. It should not change the computed final config.

"helpers:pinGitHubActionDigests"
"config:best-practices"
],
"packageRules": [
{
Expand Down
Loading
Loading