[Button]: deprecate fab prop in favor of iconOnly

[AlanBreck]

No description provided.

[github-actions]

👋 Thanks for Submitting! This PR is available for preview at the link below.

✅ PR tip preview: https://673.pr.nala.bravesoftware.com/
✅ Commit preview: https://673.pr.nala.bravesoftware.com/commit-890f229310a80097872e96608f350bb4830208eb/

- ./tokens/css/variables-android.old.css: 7424 bytes
+ ./tokens/css/variables-android.css: 7424 bytes
---
- ./tokens/css/variables-browser.old.css: 19178 bytes
+ ./tokens/css/variables-browser.css: 19178 bytes
---
- ./tokens/css/variables-ios.old.css: 7067 bytes
+ ./tokens/css/variables-ios.css: 7067 bytes
---
- ./tokens/css/variables-marketing.old.css: 13561 bytes
+ ./tokens/css/variables-marketing.css: 13561 bytes
---
- ./tokens/css/variables-news.old.css: 526 bytes
+ ./tokens/css/variables-news.css: 526 bytes
---
- ./tokens/css/variables-newtab.old.css: 1941 bytes
+ ./tokens/css/variables-newtab.css: 1941 bytes
---
- ./tokens/css/variables-search.old.css: 2419 bytes
+ ./tokens/css/variables-search.css: 2419 bytes
---
- ./tokens/css/variables-web3.old.css: 905 bytes
+ ./tokens/css/variables-web3.css: 905 bytes
---
- ./tokens/css/variables.old.css: 57399 bytes
+ ./tokens/css/variables.css: 57399 bytes

Variables Diff: variables-android.diff

--- ./tokens/css/variables-android.old.css	2024-05-14 03:34:59.445321551 +0000
+++ ./tokens/css/variables-android.css	2024-05-14 03:34:17.468562552 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Tue May 14 2024 02:28:31 GMT+0000 (Coordinated Universal Time)
+ * Generated on Tue May 14 2024 03:34:17 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-browser.diff

--- ./tokens/css/variables-browser.old.css	2024-05-14 03:34:59.941330687 +0000
+++ ./tokens/css/variables-browser.css	2024-05-14 03:34:17.432561721 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Tue May 14 2024 02:28:31 GMT+0000 (Coordinated Universal Time)
+ * Generated on Tue May 14 2024 03:34:17 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-ios.diff

--- ./tokens/css/variables-ios.old.css	2024-05-14 03:35:00.449340040 +0000
+++ ./tokens/css/variables-ios.css	2024-05-14 03:34:17.488563014 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Tue May 14 2024 02:28:31 GMT+0000 (Coordinated Universal Time)
+ * Generated on Tue May 14 2024 03:34:17 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-marketing.diff

--- ./tokens/css/variables-marketing.old.css	2024-05-14 03:35:00.789346302 +0000
+++ ./tokens/css/variables-marketing.css	2024-05-14 03:34:17.512563568 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Tue May 14 2024 02:28:31 GMT+0000 (Coordinated Universal Time)
+ * Generated on Tue May 14 2024 03:34:17 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-news.diff

--- ./tokens/css/variables-news.old.css	2024-05-14 03:35:01.125352487 +0000
+++ ./tokens/css/variables-news.css	2024-05-14 03:34:17.548564399 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Tue May 14 2024 02:28:31 GMT+0000 (Coordinated Universal Time)
+ * Generated on Tue May 14 2024 03:34:17 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-newtab.diff

--- ./tokens/css/variables-newtab.old.css	2024-05-14 03:35:01.497359339 +0000
+++ ./tokens/css/variables-newtab.css	2024-05-14 03:34:17.556564584 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Tue May 14 2024 02:28:31 GMT+0000 (Coordinated Universal Time)
+ * Generated on Tue May 14 2024 03:34:17 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-search.diff

--- ./tokens/css/variables-search.old.css	2024-05-14 03:35:01.913367000 +0000
+++ ./tokens/css/variables-search.css	2024-05-14 03:34:17.540564215 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Tue May 14 2024 02:28:31 GMT+0000 (Coordinated Universal Time)
+ * Generated on Tue May 14 2024 03:34:17 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-web3.diff

--- ./tokens/css/variables-web3.old.css	2024-05-14 03:35:02.293373994 +0000
+++ ./tokens/css/variables-web3.css	2024-05-14 03:34:17.560564676 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Tue May 14 2024 02:28:31 GMT+0000 (Coordinated Universal Time)
+ * Generated on Tue May 14 2024 03:34:17 GMT+0000 (Coordinated Universal Time)
  */
 
 @media (prefers-color-scheme: light) {

Variables Diff: variables.diff

--- ./tokens/css/variables.old.css	2024-05-14 03:35:02.713381733 +0000
+++ ./tokens/css/variables.css	2024-05-14 03:34:17.316559043 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Tue May 14 2024 02:28:31 GMT+0000 (Coordinated Universal Time)
+ * Generated on Tue May 14 2024 03:34:17 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

[fallaciousreasoning]

Approving - this is a definite improvement, but do you mind holding off merging it for a couple of days - want to try and get the NTP Search stuff landed, and it might require Nala bumps (and this will make bumping Nala complicated 😆 )

[AlanBreck]

but do you mind holding off merging it for a couple of days

Not at all.

[fallaciousreasoning]

Just wondering out loud - could we change the prop to be icon so I can write

<Button icon kind="outline">...</Button>

more wondering, but could it Just Work (tm) if you only slot in an Icon? Or is that too magic

[AlanBreck]

So we decided to split this out into an IconButton instead of a prop, yes? cc @fallaciousreasoning @petemill