Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency adblock-rs to v0.9.2 #988

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Oct 2, 2024

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
adblock-rs 0.8.12 -> 0.9.2 age adoption passing confidence

Release Notes

brave/adblock-rust (adblock-rs)

v0.9.2

Compare Source

v0.9.1

Compare Source

v0.9.0

Compare Source


Configuration

📅 Schedule: Branch creation - "* 0-4 * * 3" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot force-pushed the renovate/adblock-rs-0.x branch 3 times, most recently from 4a3c819 to 353dd0c Compare October 5, 2024 11:58
Copy link
Contributor

github-actions bot commented Oct 5, 2024

[puLL-Merge] - brave/[email protected]

Description

This PR makes significant changes to the adblock-rust library, including updates to version numbers, changes to cosmetic filter handling, improvements to scriptlet resource management, and various other enhancements and refactoring.

Possible Issues

  1. The changes to cosmetic filter handling may affect how certain filters are processed and applied, potentially leading to differences in ad-blocking behavior.
  2. The new scriptlet resource management system might have edge cases or performance implications that need further testing.

Security Hotspots

  1. The changes to the CosmeticFilter struct and related functions could potentially introduce new ways for malicious filters to be interpreted or executed. Careful review of these changes is necessary to ensure no new vulnerabilities are introduced.
Changes

Changes

  1. Cargo.toml and Cargo.lock:

    • Updated version numbers for the adblock crate and its dependencies.
    • Made serde_json a required dependency instead of optional.
  2. README.md:

    • Updated the NodeJS example file extension from .js to .mjs.
  3. src/content_blocking.rs:

    • Added support for procedural cosmetic filters.
    • Updated error handling for content blocking rule creation.
  4. src/cosmetic_filter_cache.rs:

    • Significant refactoring of the UrlSpecificResources struct and related functions.
    • Added support for procedural actions in cosmetic filters.
    • Improved handling of CSS selectors and procedural operators.
  5. src/data_format/v0.rs:

    • Updated serialization and deserialization logic to support new cosmetic filter structure.
  6. src/engine.rs:

    • Minor changes to test cases to reflect new scriptlet injection behavior.
  7. src/filters/cosmetic.rs:

    • Major refactoring of the CosmeticFilter struct and related enums.
    • Added support for procedural cosmetic filter operators.
    • Updated parsing and validation logic for cosmetic filters.
  8. src/filters/network.rs:

    • Minor refactoring and code organization changes.
  9. src/resources/resource_storage.rs:

    • Significant improvements to scriptlet resource management.
    • Added support for recursive dependencies in scriptlet resources.
    • Updated scriptlet injection logic to handle multiple injections and dependencies.

These changes represent a substantial update to the library's functionality, particularly in how it handles cosmetic filters and scriptlet resources. The PR aims to improve the flexibility and capabilities of the ad-blocking engine, but careful testing and review are necessary to ensure compatibility and security.

@renovate renovate bot changed the title fix(deps): update dependency adblock-rs to v0.9.0 fix(deps): update dependency adblock-rs to v0.9.1 Oct 7, 2024
@renovate renovate bot force-pushed the renovate/adblock-rs-0.x branch 4 times, most recently from bfb8d23 to 5c182da Compare October 13, 2024 13:34
@renovate renovate bot force-pushed the renovate/adblock-rs-0.x branch 4 times, most recently from 54d5d33 to 4ad377c Compare October 17, 2024 16:25
Copy link
Contributor

[puLL-Merge] - brave/[email protected]

Description

This PR makes significant changes to the adblock-rust library, updating its version from 0.8.12 to 0.9.1. The changes include improvements to cosmetic filtering, scriptlet handling, and overall code structure. Key modifications include support for procedural cosmetic filters, changes in how scriptlets and their dependencies are handled, and updates to various data structures and functions throughout the codebase.

Possible Issues

  1. The changes to cosmetic filter handling might affect existing filter lists or applications using the library.
  2. The new scriptlet dependency resolution system could potentially introduce performance overhead for complex scriptlet chains.

Security Hotspots

  1. The changes to regex handling in src/filters/network.rs now use BytesRegex instead of Regex. This change should be carefully reviewed to ensure it doesn't introduce any new vulnerabilities or unexpected behavior.

  2. The new scriptlet dependency resolution system in src/resources/resource_storage.rs could potentially be exploited if not properly implemented. Ensure that there are no circular dependencies or ways to abuse this system.

Changes

Changes

  1. Cargo.toml and Cargo.lock:

    • Updated version to 0.9.1
    • Made serde_json a required dependency instead of optional
  2. src/cosmetic_filter_cache.rs:

    • Introduced ProceduralOrActionFilter struct for handling procedural filters
    • Modified UrlSpecificResources to include procedural_actions
    • Updated CosmeticFilterCache to handle procedural filters
  3. src/filters/cosmetic.rs:

    • Added support for procedural cosmetic filters
    • Introduced CosmeticFilterOperator enum for different filter operations
    • Modified CosmeticFilter struct to use Vec<CosmeticFilterOperator> instead of a single String for selectors
  4. src/filters/network.rs:

    • Updated regex handling to use BytesRegex instead of Regex
    • Modified CompiledRegex to work with byte slices instead of strings
  5. src/resources/resource_storage.rs:

    • Implemented a new system for handling scriptlet dependencies
    • Added get_scriptlet_resources method to handle multiple scriptlets and their dependencies
    • Modified get_scriptlet_resource to work with the new dependency system
  6. Various other files:

    • Updated tests to accommodate the new changes
    • Made minor adjustments and improvements throughout the codebase

These changes represent a significant update to the library's functionality, particularly in how it handles cosmetic filters and scriptlets. The PR appears to be well-structured and includes appropriate test updates, but careful review and testing are recommended due to the extent of the changes.

@renovate renovate bot changed the title fix(deps): update dependency adblock-rs to v0.9.1 fix(deps): update dependency adblock-rs to v0.9.2 Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants